Bug 40348 - [chromium] Menu key should act on current selection even if it is not editable
Summary: [chromium] Menu key should act on current selection even if it is not editable
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-08 21:01 PDT by Evan Stade
Modified: 2010-06-12 19:10 PDT (History)
4 users (show)

See Also:

Attachments
patch (1.27 KB, patch)
2010-06-08 21:03 PDT, Evan Stade 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Evan Stade 2010-06-08 21:01:12 PDT 
In r52124, I reworked the menu key in a way that made it so that it only acted on selections in an editable node. A user pointed this out in <http://crbug.com/45434>. This reverts it to the old behavior. The rest of the issues that I fixed previously (see <https://bugs.webkit.org/show_bug.cgi?id=32347>) are unaffected.
Comment 1 Evan Stade 2010-06-08 21:03:48 PDT 
Created attachment 58208 [details]
patch
Comment 2 Tony Chang 2010-06-08 22:34:27 PDT 
Is it possible to test this with eventSender.keyDown or does it not know about this key?  Can we add this key to the method?
Comment 3 Evan Stade 2010-06-09 11:22:01 PDT 
we could test it with eventSender.keyDown, but I'm not sure how we'd verify that it's doing what we want from within a layout test. It's probably better suited to test via a chromium UI test.
Comment 4 Eric Seidel (no email) 2010-06-12 18:58:42 PDT 
Comment on attachment 58208 [details]
patch

OK.  rs=me.
Comment 5 WebKit Commit Bot 2010-06-12 19:09:54 PDT 
Comment on attachment 58208 [details]
patch

Clearing flags on attachment: 58208

Committed r61072: <http://trac.webkit.org/changeset/61072>
Comment 6 WebKit Commit Bot 2010-06-12 19:10:08 PDT 
All reviewed patches have been landed.  Closing bug.