Bug 40345 - Don't send mail for cancel/deny/granted for in-rietveld
Summary: Don't send mail for cancel/deny/granted for in-rietveld
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Julie Parent
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-08 18:07 PDT by Julie Parent
Modified: 2010-06-09 17:35 PDT (History)
3 users (show)

See Also:


Attachments
patch (1.14 KB, patch)
2010-06-09 10:56 PDT, Julie Parent
ddkilzer: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Julie Parent 2010-06-08 18:07:23 PDT
We already don't send the regular flag change mail, but we also shouldn't send the specific mail for cancel/deny/granted that comes from state change from ? -> {+,-, ).
Comment 1 Julie Parent 2010-06-09 10:56:19 PDT
Created attachment 58261 [details]
patch
Comment 2 Adam Barth 2010-06-09 11:13:17 PDT
Comment on attachment 58261 [details]
patch

LGTM, but BugsSite and I aren't friends.  :)
Comment 3 David Kilzer (:ddkilzer) 2010-06-09 11:17:37 PDT
Comment on attachment 58261 [details]
patch

r=me
Comment 4 Julie Parent 2010-06-09 17:35:40 PDT
Committed http://trac.webkit.org/changeset/60904