Bug 40341 - [chromium] webkit_unit_tests project fails to link when ACCELERATED_COMPOSITING is enabled
Summary: [chromium] webkit_unit_tests project fails to link when ACCELERATED_COMPOSITI...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-08 16:01 PDT by Vangelis Kokkevis
Modified: 2010-06-11 05:29 PDT (History)
4 users (show)

See Also:

Attachments
Proposed patch (1.59 KB, patch)
2010-06-08 16:47 PDT, Vangelis Kokkevis 		no flags Details | Formatted Diff | Diff
Re-uploading the patch to kick the try bots on (1.59 KB, patch)
2010-06-10 11:20 PDT, Vangelis Kokkevis 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vangelis Kokkevis 2010-06-08 16:01:21 PDT 
The unresolved symbols come from the lack of linking with the gles2 C library:
webcore.lib(LayerRendererChromium.obj) : error LNK2019: unresolved external symbol _GLES2DeleteTextures referenced in function "public: __thiscall WebCore::LayerRendererChromium::~LayerRendererChromium(void)" (??1LayerRendererChromium@WebCore@@QAE@XZ)
....
Comment 1 Vangelis Kokkevis 2010-06-08 16:47:34 PDT 
Created attachment 58196 [details]
Proposed patch
Comment 2 WebKit Review Bot 2010-06-08 20:40:47 PDT 
Attachment 58196 [details] did not build on chromium:
Build output: http://webkit-commit-queue.appspot.com/results/3238069
Comment 3 Darin Fisher (:fishd, Google) 2010-06-08 21:58:50 PDT 
^^^ looks like we need to add the angle project to chromium/DEPS?
Comment 4 David Levin 2010-06-09 09:10:02 PDT 
Comment on attachment 58196 [details]
Proposed patch

r- due to cr-linux build break.
Comment 5 Vangelis Kokkevis 2010-06-10 10:23:17 PDT 
Comment on attachment 58196 [details]
Proposed patch

Hopefully now that ANGLE is in the DEPS file this will actually compile.
Comment 6 Vangelis Kokkevis 2010-06-10 11:20:28 PDT 
Created attachment 58394 [details]
Re-uploading the patch to kick the try bots on
Comment 7 Vangelis Kokkevis 2010-06-10 13:01:45 PDT 
Looks like it's ready to go, this time!
Comment 8 WebKit Commit Bot 2010-06-11 05:28:55 PDT 
Comment on attachment 58394 [details]
Re-uploading the patch to kick the try bots on

Clearing flags on attachment: 58394

Committed r61007: <http://trac.webkit.org/changeset/61007>
Comment 9 WebKit Commit Bot 2010-06-11 05:29:03 PDT 
All reviewed patches have been landed.  Closing bug.