RESOLVED FIXED Bug 40341
[chromium] webkit_unit_tests project fails to link when ACCELERATED_COMPOSITING is enabled 
https://bugs.webkit.org/show_bug.cgi?id=40341
Summary [chromium] webkit_unit_tests project fails to link when ACCELERATED_COMPOSITI...
Vangelis Kokkevis
Reported 2010-06-08 16:01:21 PDT
The unresolved symbols come from the lack of linking with the gles2 C library: webcore.lib(LayerRendererChromium.obj) : error LNK2019: unresolved external symbol _GLES2DeleteTextures referenced in function "public: __thiscall WebCore::LayerRendererChromium::~LayerRendererChromium(void)" (??1LayerRendererChromium@WebCore@@QAE@XZ) ....
Attachments
Proposed patch (1.59 KB, patch)
2010-06-08 16:47 PDT, Vangelis Kokkevis 		no flags
DetailsFormatted DiffDiff
Re-uploading the patch to kick the try bots on (1.59 KB, patch)
2010-06-10 11:20 PDT, Vangelis Kokkevis 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Vangelis Kokkevis
Comment 1 2010-06-08 16:47:34 PDT
Created attachment 58196 [details] Proposed patch
WebKit Review Bot
Comment 2 2010-06-08 20:40:47 PDT
Attachment 58196 [details] did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/3238069
Darin Fisher (:fishd, Google)
Comment 3 2010-06-08 21:58:50 PDT
^^^ looks like we need to add the angle project to chromium/DEPS?
David Levin
Comment 4 2010-06-09 09:10:02 PDT
Comment on attachment 58196 [details] Proposed patch r- due to cr-linux build break.
Vangelis Kokkevis
Comment 5 2010-06-10 10:23:17 PDT
Comment on attachment 58196 [details] Proposed patch Hopefully now that ANGLE is in the DEPS file this will actually compile.
Vangelis Kokkevis
Comment 6 2010-06-10 11:20:28 PDT
Created attachment 58394 [details] Re-uploading the patch to kick the try bots on
Vangelis Kokkevis
Comment 7 2010-06-10 13:01:45 PDT
Looks like it's ready to go, this time!
WebKit Commit Bot
Comment 8 2010-06-11 05:28:55 PDT
Comment on attachment 58394 [details] Re-uploading the patch to kick the try bots on Clearing flags on attachment: 58394 Committed r61007: <http://trac.webkit.org/changeset/61007>
WebKit Commit Bot
Comment 9 2010-06-11 05:29:03 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.