Bug 40333 - [GTK] Convert WebKitWebView's private draggingDataObjects member to a pointer
Summary: [GTK] Convert WebKitWebView's private draggingDataObjects member to a pointer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 30623
  Show dependency tree / graph
 
Reported: 2010-06-08 14:14 PDT by Martin Robinson
Modified: 2010-07-01 09:03 PDT (History)
3 users (show)

See Also:

Attachments
Convert draggingDataObjects to a pointer (4.63 KB, patch)
2010-06-08 14:19 PDT, Martin Robinson 		no flags Details | Formatted Diff | Diff
Alternative approach using placement new (1.72 KB, patch)
2010-06-09 14:10 PDT, Martin Robinson 		no flags Details | Formatted Diff | Diff
Patch where delete is done in finalize instead of dispose (4.87 KB, patch)
2010-07-01 08:43 PDT, Martin Robinson 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2010-06-08 14:14:37 PDT 
Converting this member to a pointer will allow for calling constructor and destructor of this HashMap. Previously a 0'd memory region was used for this object.
Comment 1 Martin Robinson 2010-06-08 14:19:33 PDT 
Created attachment 58185 [details]
Convert draggingDataObjects to a pointer
Comment 2 Martin Robinson 2010-06-09 14:10:49 PDT 
Created attachment 58295 [details]
Alternative approach using placement new
Comment 3 Martin Robinson 2010-06-29 09:23:40 PDT 
Comment on attachment 58185 [details]
Convert draggingDataObjects to a pointer

It seems like the pointer approach is preferred, so I'm re-enabling the review? flag on it.
Comment 4 Xan Lopez 2010-06-30 13:06:47 PDT 
Comment on attachment 58185 [details]
Convert draggingDataObjects to a pointer

Looks good.
Comment 5 Martin Robinson 2010-06-30 22:45:18 PDT 
Committed r62226: <http://trac.webkit.org/changeset/62226>
Comment 6 WebKit Review Bot 2010-06-30 23:13:04 PDT 
http://trac.webkit.org/changeset/62226 might have broken GTK Linux 32-bit Release
Comment 7 Martin Robinson 2010-06-30 23:25:19 PDT 
Reverted r62226 for reason:

This change caused 13 new crashers.

Committed r62230: <http://trac.webkit.org/changeset/62230>
Comment 8 Martin Robinson 2010-07-01 08:43:28 PDT 
Created attachment 60253 [details]
Patch where delete is done in finalize instead of dispose
Comment 9 Xan Lopez 2010-07-01 08:57:43 PDT 
Comment on attachment 60253 [details]
Patch where delete is done in finalize instead of dispose

13 crashers!
Comment 10 Martin Robinson 2010-07-01 09:03:12 PDT 
Comment on attachment 60253 [details]
Patch where delete is done in finalize instead of dispose

Clearing flags on attachment: 60253

Committed r62262: <http://trac.webkit.org/changeset/62262>
Comment 11 Martin Robinson 2010-07-01 09:03:18 PDT 
All reviewed patches have been landed.  Closing bug.