Bug 40332 - [Qt] Text breaking is slow: enable ICU as an opt-in
Summary: [Qt] Text breaking is slow: enable ICU as an opt-in
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords: Performance, Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2010-06-08 14:02 PDT by Noam Rosenthal
Modified: 2010-10-14 09:57 PDT (History)
7 users (show)

See Also:


Attachments
compile flag for Qt+ICU (7.38 KB, patch)
2010-06-08 14:05 PDT, Noam Rosenthal
no flags Details | Formatted Diff | Diff
Patch (14.42 KB, patch)
2010-10-12 07:11 PDT, Noam Rosenthal
kling: review-
Details | Formatted Diff | Diff
Patch (7.23 KB, patch)
2010-10-12 09:03 PDT, Noam Rosenthal
no flags Details | Formatted Diff | Diff
Patch (7.26 KB, patch)
2010-10-12 09:40 PDT, Noam Rosenthal
commit-queue: commit-queue-
Details | Formatted Diff | Diff
Patch (7.22 KB, patch)
2010-10-14 02:10 PDT, Noam Rosenthal
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Noam Rosenthal 2010-06-08 14:02:16 PDT
Right now Qt is the only port that doesn't use ICU for text breaking. That causes bottlenecks in some use cases.
Proposing to allow ICU as an option.
Comment 1 Noam Rosenthal 2010-06-08 14:05:48 PDT
Created attachment 58178 [details]
compile flag for Qt+ICU
Comment 2 Eric Seidel (no email) 2010-06-12 19:00:20 PDT
Comment on attachment 58178 [details]
compile flag for Qt+ICU

Please do not use c-style casts.
Comment 3 Noam Rosenthal 2010-10-12 07:11:34 PDT
Created attachment 70529 [details]
Patch
Comment 4 Andreas Kling 2010-10-12 07:20:46 PDT
Comment on attachment 70529 [details]
Patch

This patch is full of unrelated gunk :)
Comment 5 Noam Rosenthal 2010-10-12 09:00:44 PDT
oops, sorry ;)
will resubmit
Comment 6 Noam Rosenthal 2010-10-12 09:03:34 PDT
Created attachment 70534 [details]
Patch

No unrelated junk this time
Comment 7 Andreas Kling 2010-10-12 09:30:25 PDT
Comment on attachment 70534 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=70534&action=review

LGTM. Curious to see how much faster this is. :-)

> JavaScriptCore/ChangeLog:10
> +

Extra newline.
Comment 8 Noam Rosenthal 2010-10-12 09:40:11 PDT
Created attachment 70536 [details]
Patch

Removed extra line.
Comment 9 WebKit Commit Bot 2010-10-12 09:58:45 PDT
Comment on attachment 70536 [details]
Patch

Rejecting patch 70536 from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'land-attachment', '--force-clean', '--ignore-builders', '--quiet', '--non-interactive', '--parent-command=commit-queue', 70536]" exit_code: 1
Last 500 characters of output:
ng: https://bugs.webkit.org/show_bug.cgi?id=40332&ctype=xml
Processing 1 patch from 1 bug.
Cleaning working directory
Updating working directory
Processing patch 70536 from bug 40332.
Andreas Kling <kling@webkit.org> found in /Projects/CommitQueue/JavaScriptCore/ChangeLog does not appear to be a valid reviewer according to committers.py.
ERROR: /Projects/CommitQueue/JavaScriptCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/4371021
Comment 10 Noam Rosenthal 2010-10-12 14:18:37 PDT
Had to put it on r? again after removing the extra line, because for some reason it didn't work automatically for me to add Andreas as a rev-by...

Am I doing something wrong?
Comment 11 Kenneth Rohde Christiansen 2010-10-12 16:27:29 PDT
Do not add review? in that case
Comment 12 WebKit Commit Bot 2010-10-12 17:48:22 PDT
Comment on attachment 70536 [details]
Patch

Rejecting patch 70536 from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'land-attachment', '--force-clean', '--ignore-builders', '--quiet', '--non-interactive', '--parent-command=commit-queue', 70536]" exit_code: 1
Last 500 characters of output:
ng: https://bugs.webkit.org/show_bug.cgi?id=40332&ctype=xml
Processing 1 patch from 1 bug.
Cleaning working directory
Updating working directory
Processing patch 70536 from bug 40332.
Andreas Kling <kling@webkit.org> found in /Projects/CommitQueue/JavaScriptCore/ChangeLog does not appear to be a valid reviewer according to committers.py.
ERROR: /Projects/CommitQueue/JavaScriptCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/4409001
Comment 13 Andreas Kling 2010-10-13 02:28:37 PDT
It's probably choking on the " <kling@webkit.org>" in the revby field.
Comment 14 Noam Rosenthal 2010-10-14 02:10:22 PDT
Created attachment 70719 [details]
Patch
Comment 15 Eric Seidel (no email) 2010-10-14 07:18:37 PDT
Comment on attachment 70534 [details]
Patch

Cleared review+ from obsolete attachment 70534 [details] so that this bug does not appear in http://webkit.org/pending-commit.
Comment 16 WebKit Commit Bot 2010-10-14 09:57:13 PDT
Comment on attachment 70719 [details]
Patch

Clearing flags on attachment: 70719

Committed r69773: <http://trac.webkit.org/changeset/69773>
Comment 17 WebKit Commit Bot 2010-10-14 09:57:24 PDT
All reviewed patches have been landed.  Closing bug.