Bug 40332 – [Qt] Text breaking is slow: enable ICU as an opt-in

• Status: RESOLVED
• Resolution: FIXED
• Component: Text

[Noam Rosenthal]

Right now Qt is the only port that doesn't use ICU for text breaking. That causes bottlenecks in some use cases.
Proposing to allow ICU as an option.

[Noam Rosenthal]

Created attachment 58178 [details]
compile flag for Qt+ICU

[Eric Seidel (no email)]

Comment on attachment 58178 [details]
compile flag for Qt+ICU

Please do not use c-style casts.

[Noam Rosenthal]

Created attachment 70529 [details]
Patch

[Andreas Kling]

Comment on attachment 70529 [details]
Patch

This patch is full of unrelated gunk :)

[Noam Rosenthal]

oops, sorry ;)
will resubmit

[Noam Rosenthal]

Created attachment 70534 [details]
Patch

No unrelated junk this time

[Andreas Kling]

Comment on attachment 70534 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=70534&action=review

LGTM. Curious to see how much faster this is. :-)

> JavaScriptCore/ChangeLog:10
> +

Extra newline.

[Noam Rosenthal]

Created attachment 70536 [details]
Patch

Removed extra line.

[WebKit Commit Bot]

Comment on attachment 70536 [details]
Patch

Rejecting patch 70536 from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'land-attachment', '--force-clean', '--ignore-builders', '--quiet', '--non-interactive', '--parent-command=commit-queue', 70536]" exit_code: 1
Last 500 characters of output:
ng: https://bugs.webkit.org/show_bug.cgi?id=40332&ctype=xml
Processing 1 patch from 1 bug.
Cleaning working directory
Updating working directory
Processing patch 70536 from bug 40332.
Andreas Kling <[e-mail]> found in /Projects/CommitQueue/JavaScriptCore/ChangeLog does not appear to be a valid reviewer according to committers.py.
ERROR: /Projects/CommitQueue/JavaScriptCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/4371021

[Noam Rosenthal]

Had to put it on r? again after removing the extra line, because for some reason it didn't work automatically for me to add Andreas as a rev-by...

Am I doing something wrong?

[Kenneth Rohde Christiansen]

Do not add review? in that case

[WebKit Commit Bot]

Comment on attachment 70536 [details]
Patch

Rejecting patch 70536 from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'land-attachment', '--force-clean', '--ignore-builders', '--quiet', '--non-interactive', '--parent-command=commit-queue', 70536]" exit_code: 1
Last 500 characters of output:
ng: https://bugs.webkit.org/show_bug.cgi?id=40332&ctype=xml
Processing 1 patch from 1 bug.
Cleaning working directory
Updating working directory
Processing patch 70536 from bug 40332.
Andreas Kling <[e-mail]> found in /Projects/CommitQueue/JavaScriptCore/ChangeLog does not appear to be a valid reviewer according to committers.py.
ERROR: /Projects/CommitQueue/JavaScriptCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/4409001

[Andreas Kling]

It's probably choking on the " <[e-mail]>" in the revby field.

[Noam Rosenthal]

Created attachment 70719 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 70534 [details]
Patch

Cleared review+ from obsolete attachment 70534 [details] so that this bug does not appear in http://webkit.org/pending-commit.

[WebKit Commit Bot]

Comment on attachment 70719 [details]
Patch

Clearing flags on attachment: 70719

Committed r69773: <http://trac.webkit.org/changeset/69773>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.