Bug 40330 - [Qt] Add support for callShouldCloseOnWebView() to DRT
Summary: [Qt] Add support for callShouldCloseOnWebView() to DRT
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Robert Hogan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-08 13:41 PDT by Robert Hogan
Modified: 2010-06-13 06:30 PDT (History)
0 users

See Also:

Attachments
Patch (6.26 KB, patch)
2010-06-08 13:45 PDT, Robert Hogan 		eric: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Hogan 2010-06-08 13:41:59 PDT 
[Qt] Add support for callShouldCloseOnWebView() to DRT
Comment 1 Robert Hogan 2010-06-08 13:45:40 PDT 
Created attachment 58176 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-06-12 19:01:41 PDT 
Comment on attachment 58176 [details]
Patch

Why the void setCallCloseOnWebViews() {} change?  Seems unrelated.  please remove if not needed.
Comment 3 Robert Hogan 2010-06-13 03:22:18 PDT 
(In reply to comment #2)
> (From update of attachment 58176 [details])
> Why the void setCallCloseOnWebViews() {} change?  Seems unrelated.  please remove if not needed.

On Qt I think it just needs to be supported as a no-op. Adding it also allows the real DRT bug in plugins/open-and-close-window-with-plugin.html and plugins/geturlnotify-during-document-teardown.html to be exposed. This is tracked at https://bugs.webkit.org/show_bug.cgi?id=33333.

I'll add a comment to it so people know why it's there.
Comment 4 Robert Hogan 2010-06-13 06:30:10 PDT 
Committed r61090: <http://trac.webkit.org/changeset/61090>