Bug 40324 - [Qt] DRT EventSender support to graphics context events
Summary: [Qt] DRT EventSender support to graphics context events
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Diego Gonzalez
URL:
Keywords: Qt
Depends on:
Blocks: 40014
  Show dependency treegraph
 
Reported: 2010-06-08 12:35 PDT by Diego Gonzalez
Modified: 2010-06-15 06:32 PDT (History)
7 users (show)

See Also:


Attachments
Patch (2.27 KB, patch)
2010-06-11 11:32 PDT, Diego Gonzalez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Gonzalez 2010-06-08 12:35:32 PDT
Make possible to run context menu test in graphics based view mode
Comment 1 Diego Gonzalez 2010-06-11 11:32:50 PDT
Created attachment 58490 [details]
Patch
Comment 2 Antonio Gomes 2010-06-11 11:40:13 PDT
(In reply to comment #1)
> Created an attachment (id=58490) [details]
> Patch

lgtm
Comment 3 Kenneth Rohde Christiansen 2010-06-11 16:35:09 PDT
Comment on attachment 58490 [details]
Patch

WebKitTools/DumpRenderTree/qt/EventSenderQt.cpp:347
 +          WebCore::WebViewGraphicsBased* view = qobject_cast<WebCore::WebViewGraphicsBased*>(m_page->view());
as you sure this is right? We normally do not set the view when dealing with QGraphicsWebView. And even if you set it, it seems like a hack. It would be nice to do this in another way

Anyway, looks fine.
Comment 4 Diego Gonzalez 2010-06-14 08:01:11 PDT
Comment on attachment 58490 [details]
Patch

Just to do some tests
Comment 5 WebKit Commit Bot 2010-06-15 06:21:55 PDT
Comment on attachment 58490 [details]
Patch

Clearing flags on attachment: 58490

Committed r61184: <http://trac.webkit.org/changeset/61184>
Comment 6 WebKit Commit Bot 2010-06-15 06:22:02 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 WebKit Review Bot 2010-06-15 06:28:06 PDT
http://trac.webkit.org/changeset/61184 might have broken Qt Linux Release minimal
Comment 8 Antonio Gomes 2010-06-15 06:32:40 PDT
(In reply to comment #7)
> http://trac.webkit.org/changeset/61184 might have broken Qt Linux Release minimal

diego, you possibly need this  #ifndef QT_NO_CONTEXTMENU wrapping the code