Bug 40323 - Rename FloatArray to Float32Array
Summary: Rename FloatArray to Float32Array
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Kenneth Russell
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-08 12:13 PDT by Kenneth Russell
Modified: 2010-06-09 11:24 PDT (History)
4 users (show)

See Also:

Attachments
Partial patch (17.18 KB, patch)
2010-06-09 10:59 PDT, Kenneth Russell 		dglazkov: review+
kbr: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Russell 2010-06-08 12:13:25 PDT 
Per recent TypedArray spec updates, FloatArray must be renamed to Float32Array.
Comment 1 Kenneth Russell 2010-06-09 10:59:01 PDT 
Created attachment 58262 [details]
Partial patch

This is a *partial* patch containing only the ChangeLogs and those files which were modified by hand. It will not pass the bots. The full patch is over 100k but all of the changes and renames in it are handled by the do-webcore-rename script, the changes to which are in the patch.

Description from the ChangeLog:

Used do-webcore-rename to perform renaming. Manually undid incorrect changes to WebCore/bridge/jni/jsc/JNIBridgeJSC.cpp, WebCore/manual-tests/resources/ArrayParameterTestApplet.java and ArrayParameterTestApplet.class. Updated LayoutTests. Built and ran all layout tests on Safari; built Chromium and ran selected WebGL tests.
Comment 2 Dimitri Glazkov (Google) 2010-06-09 11:08:56 PDT 
Comment on attachment 58262 [details]
Partial patch

rs=me. Godspeed, kbr.
Comment 3 Dimitri Glazkov (Google) 2010-06-09 11:19:33 PDT 
Comment on attachment 58262 [details]
Partial patch

doh.
Comment 4 Kenneth Russell 2010-06-09 11:24:32 PDT 
Committed r60902: <http://trac.webkit.org/changeset/60902>