Bug 40322 - Update readPixels to take ArrayBufferView rather than returning it
Summary: Update readPixels to take ArrayBufferView rather than returning it
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Kenneth Russell
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-08 12:08 PDT by Kenneth Russell
Modified: 2010-06-09 14:40 PDT (History)
5 users (show)

See Also:


Attachments
Patch (26.43 KB, patch)
2010-06-09 14:06 PDT, Kenneth Russell
kbr: commit-queue-
Details | Formatted Diff | Diff
Revised patch (26.41 KB, patch)
2010-06-09 14:10 PDT, Kenneth Russell
dglazkov: review+
kbr: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Russell 2010-06-08 12:08:56 PDT
Per recent updates to the WebGL spec, readPixels must be updated to take an ArrayBufferView as argument rather than returning a newly allocated one. Checks on the type and size of the passed array must be implemented.
Comment 1 Kenneth Russell 2010-06-09 11:45:56 PDT
I've already got a patch in progress for this one. Reassigning to myself.
Comment 2 Kenneth Russell 2010-06-09 14:06:46 PDT
Created attachment 58293 [details]
Patch

Self-explanatory.

Ran WebGL tests in WebKit; testing in Chromium in progress and will be completed before checkin.
Comment 3 Kenneth Russell 2010-06-09 14:10:33 PDT
Created attachment 58294 [details]
Revised patch

Fixed minor style issue in read-pixels.html test.
Comment 4 Dimitri Glazkov (Google) 2010-06-09 14:12:49 PDT
Comment on attachment 58294 [details]
Revised patch

ok.
Comment 5 Kenneth Russell 2010-06-09 14:40:03 PDT
Committed r60914: <http://trac.webkit.org/changeset/60914>