Bug 40312 – [chromium] Track state for whether a ResourceRequest is fetched via a proxy

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Mike Belshe]

Track whether a page is fetched via a proxy.

[Mike Belshe]

Created attachment 58204 [details]
Simple patch - chromium specific.

[David Levin]

Not sure if it matters but these fields will not be copied across threads (see PassOwnPtr<CrossThreadResourceRequestData> copyData() const;). This is called when workers do resource requests.

Other: The reviewer typically isn't filled in until someone has r+'ed it.

[Mike Belshe]

Yes, CrossThreadResourceRequestData can't deal with platform specific flags.  So this is no change.

re the Reviewer:  I know.  I take a crap-shoot at the reviewer.  If Dimitry reviews it, then I don't need to regenerate a patch.  A better fix would be to get rid of ChangeLogs, but I think that is an issue for the Office of Redundancy to tackle...

[David Levin]

(In reply to comment #3)
> Yes, CrossThreadResourceRequestData can't deal with platform specific flags.  So this is no change.

Well, it doesn't at present. I suppose it should be modified to handle platform specific flags if they matter (when it is called).

Specifically, this method is called when workers do resource requests. Do these fields matter for that case?

[Mike Belshe]

(In reply to comment #4)
> Specifically, this method is called when workers do resource requests. Do these fields matter for that case?

We're trying to track at a page-load-level whether a page is "proxied or not".  This already has room for error, because some resources on a page could be proxied, and others may not.  We use the base-page as the trigger for how to label the page load.  Since we're only looking at page loads, not resources loaded by XHR, workers, etc, it doesn't matter for workers.

[David Levin]

(In reply to comment #5)
> (In reply to comment #4)
> > Specifically, this method is called when workers do resource requests. Do these fields matter for that case?
> 
> We're trying to track at a page-load-level whether a page is "proxied or not".  This already has room for error, because some resources on a page could be proxied, and others may not.  We use the base-page as the trigger for how to label the page load.  Since we're only looking at page loads, not resources loaded by XHR, workers, etc, it doesn't matter for workers.

Thanks!

[Mike Belshe]

Created attachment 58269 [details]
Update the reviewer field .

[Mike Belshe]

Created attachment 58271 [details]
One more try, without tagalong fixes.

[WebKit Commit Bot]

Comment on attachment 58271 [details]
One more try, without tagalong fixes.

Clearing flags on attachment: 58271

Committed r60955: <http://trac.webkit.org/changeset/60955>

[Noam Rosenthal]

*** Bug 43011 has been marked as a duplicate of this bug. ***

[Adam Barth]

This patch claims to have been landed.