RESOLVED FIXED 40307
[GTK] DragDataGtk should use DataObjectGtk as the platformDragData 
https://bugs.webkit.org/show_bug.cgi?id=40307
Summary [GTK] DragDataGtk should use DataObjectGtk as the platformDragData
Martin Robinson
Reported Tuesday, June 8, 2010 6:25:28 PM UTC
DataObjectGtk contains the current state of a drop, so it should be used as the platformDragData in DataObjectGtk.
Attachments
Patch (4.23 KB, patch)
2010-06-08 11:06 PDT, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Patch with Eric's suggestions (4.26 KB, patch)
2010-06-14 17:49 PDT, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 Tuesday, June 8, 2010 7:06:45 PM UTC
Created attachment 58161 [details] Patch
Eric Seidel (no email)
Comment 2 Sunday, June 13, 2010 3:06:04 AM UTC
Comment on attachment 58161 [details] Patch WebCore/platform/DragData.h:  + typedef void* DragDataRef; Can't this just be class DataObjectGtk; instead of having to include the header? WebCore/platform/gtk/DragDataGtk.cpp:93 + RefPtr<DocumentFragment> fragment(createFragmentFromMarkup(document, m_platformDragData->markup(), "")); Why store this in a ref ptr at all?
Martin Robinson
Comment 3 Tuesday, June 15, 2010 1:49:43 AM UTC
Created attachment 58735 [details] Patch with Eric's suggestions
Martin Robinson
Comment 4 Tuesday, June 15, 2010 1:50:28 AM UTC
(In reply to comment #2) Thank you for your review. I've incorporated both of your suggestions in a new patch.
Xan Lopez
Comment 5 Tuesday, June 29, 2010 1:21:55 PM UTC
Comment on attachment 58735 [details] Patch with Eric's suggestions Correctomundo.
Martin Robinson
Comment 6 Tuesday, June 29, 2010 4:38:24 PM UTC
Comment on attachment 58735 [details] Patch with Eric's suggestions Clearing flags on attachment: 58735 Committed r62124: <http://trac.webkit.org/changeset/62124>
Martin Robinson
Comment 7 Tuesday, June 29, 2010 4:38:29 PM UTC
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.