Bug 40307 - [GTK] DragDataGtk should use DataObjectGtk as the platformDragData
Summary: [GTK] DragDataGtk should use DataObjectGtk as the platformDragData
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 30623 39843
  Show dependency treegraph
 
Reported: 2010-06-08 10:25 PDT by Martin Robinson
Modified: 2010-06-29 08:38 PDT (History)
0 users

See Also:


Attachments
Patch (4.23 KB, patch)
2010-06-08 11:06 PDT, Martin Robinson
no flags Details | Formatted Diff | Diff
Patch with Eric's suggestions (4.26 KB, patch)
2010-06-14 17:49 PDT, Martin Robinson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2010-06-08 10:25:28 PDT
DataObjectGtk contains the current state of a drop, so it should be used as the platformDragData in DataObjectGtk.
Comment 1 Martin Robinson 2010-06-08 11:06:45 PDT
Created attachment 58161 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-06-12 19:06:04 PDT
Comment on attachment 58161 [details]
Patch

WebCore/platform/DragData.h: 
 +  typedef void* DragDataRef;
Can't this just be class DataObjectGtk; instead of having to include the header?

WebCore/platform/gtk/DragDataGtk.cpp:93
 +      RefPtr<DocumentFragment> fragment(createFragmentFromMarkup(document, m_platformDragData->markup(), ""));
Why store this in a ref ptr at all?
Comment 3 Martin Robinson 2010-06-14 17:49:43 PDT
Created attachment 58735 [details]
Patch with Eric's suggestions
Comment 4 Martin Robinson 2010-06-14 17:50:28 PDT
(In reply to comment #2)

Thank you for your review. I've incorporated both of your suggestions in a new patch.
Comment 5 Xan Lopez 2010-06-29 05:21:55 PDT
Comment on attachment 58735 [details]
Patch with Eric's suggestions

Correctomundo.
Comment 6 Martin Robinson 2010-06-29 08:38:24 PDT
Comment on attachment 58735 [details]
Patch with Eric's suggestions

Clearing flags on attachment: 58735

Committed r62124: <http://trac.webkit.org/changeset/62124>
Comment 7 Martin Robinson 2010-06-29 08:38:29 PDT
All reviewed patches have been landed.  Closing bug.