Bug 40297 - Web Inspector: extend ScriptDebugServer to support script source editing
Summary: Web Inspector: extend ScriptDebugServer to support script source editing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-08 06:48 PDT by Yury Semikhatsky
Modified: 2010-06-09 01:19 PDT (History)
9 users (show)

See Also:


Attachments
Patch (23.65 KB, patch)
2010-06-08 06:55 PDT, Yury Semikhatsky
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2010-06-08 06:48:34 PDT
Extend ScriptDebugServer to support script source editing.
Comment 1 Yury Semikhatsky 2010-06-08 06:55:09 PDT
Created attachment 58135 [details]
Patch
Comment 2 Pavel Feldman 2010-06-08 07:02:55 PDT
Comment on attachment 58135 [details]
Patch

Please file a bug on JSC on the missing functionality and add int into FIXME.

WebKit/chromium/src/js/DebuggerScript.js:47
 +  DebuggerScript.ScriptWorldType = {
Is this related?
Comment 3 Yury Semikhatsky 2010-06-08 07:43:25 PDT
(In reply to comment #2)
> (From update of attachment 58135 [details])
> Please file a bug on JSC on the missing functionality and add int into FIXME.
> 
Filed: https://bugs.webkit.org/show_bug.cgi?id=40300

> WebKit/chromium/src/js/DebuggerScript.js:47
>  +  DebuggerScript.ScriptWorldType = {
> Is this related?
Removed this code.
Comment 4 Yury Semikhatsky 2010-06-08 07:53:34 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/bindings/js/ScriptDebugServer.cpp
	M	WebCore/bindings/js/ScriptDebugServer.h
	M	WebCore/bindings/v8/ScriptDebugServer.cpp
	M	WebCore/bindings/v8/ScriptDebugServer.h
	M	WebCore/inspector/InspectorBackend.cpp
	M	WebCore/inspector/InspectorBackend.h
	M	WebCore/inspector/InspectorBackend.idl
	M	WebCore/inspector/InspectorController.cpp
	M	WebCore/inspector/InspectorController.h
	M	WebCore/inspector/InspectorFrontend.cpp
	M	WebCore/inspector/InspectorFrontend.h
	M	WebCore/inspector/front-end/Script.js
	M	WebCore/inspector/front-end/ScriptsPanel.js
	M	WebCore/inspector/front-end/Settings.js
	M	WebCore/inspector/front-end/SourceView.js
	M	WebCore/inspector/front-end/TextViewer.js
	M	WebKit/chromium/ChangeLog
	M	WebKit/chromium/src/js/DebuggerScript.js
	M	WebKit/chromium/src/js/DevTools.js
	M	WebKit/chromium/src/js/InspectorControllerImpl.js
Committed r60843