Bug 40290 - Android V8 seems to need to include V8Proxy.h in gnerated bindings code
Summary: Android V8 seems to need to include V8Proxy.h in gnerated bindings code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Android Android
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-08 03:34 PDT by Leon Clarke
Modified: 2010-06-09 19:41 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.13 KB, patch)
2010-06-08 05:08 PDT, Steve Block 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Leon Clarke 2010-06-08 03:34:46 PDT 
...for toV8Context(ScriptExecutionContext*, constWorldContextHandle&);
Comment 1 Steve Block 2010-06-08 05:00:11 PDT 
(In reply to comment #0)
> ...for toV8Context(ScriptExecutionContext*, constWorldContextHandle&);
toV8Context() is defined in V8Proxy.h, so it looks to me like  GenerateCallbackImplementation in CodeGeneratorV8.pm should add this include.
Comment 2 Steve Block 2010-06-08 05:08:52 PDT 
Created attachment 58130 [details]
Patch
Comment 3 Jeremy Orlow 2010-06-08 05:32:56 PDT 
Comment on attachment 58130 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2010-06-09 19:41:04 PDT 
Comment on attachment 58130 [details]
Patch

Clearing flags on attachment: 58130

Committed r60931: <http://trac.webkit.org/changeset/60931>
Comment 5 WebKit Commit Bot 2010-06-09 19:41:09 PDT 
All reviewed patches have been landed.  Closing bug.