WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
40290
Android V8 seems to need to include V8Proxy.h in gnerated bindings code
https://bugs.webkit.org/show_bug.cgi?id=40290
Summary
Android V8 seems to need to include V8Proxy.h in gnerated bindings code
Leon Clarke
Reported
2010-06-08 03:34:46 PDT
...for toV8Context(ScriptExecutionContext*, constWorldContextHandle&);
Attachments
Patch
(1.13 KB, patch)
2010-06-08 05:08 PDT
,
Steve Block
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Steve Block
Comment 1
2010-06-08 05:00:11 PDT
(In reply to
comment #0
)
> ...for toV8Context(ScriptExecutionContext*, constWorldContextHandle&);
toV8Context() is defined in V8Proxy.h, so it looks to me like GenerateCallbackImplementation in CodeGeneratorV8.pm should add this include.
Steve Block
Comment 2
2010-06-08 05:08:52 PDT
Created
attachment 58130
[details]
Patch
Jeremy Orlow
Comment 3
2010-06-08 05:32:56 PDT
Comment on
attachment 58130
[details]
Patch r=me
WebKit Commit Bot
Comment 4
2010-06-09 19:41:04 PDT
Comment on
attachment 58130
[details]
Patch Clearing flags on attachment: 58130 Committed
r60931
: <
http://trac.webkit.org/changeset/60931
>
WebKit Commit Bot
Comment 5
2010-06-09 19:41:09 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug