Bug 40289 – Web Inspector: v8 debugger should always be enabled when frontend is attached.

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Pavel Podivilov]

Web Inspector: v8 debugger should always be enabled when frontend is attached.

[Pavel Podivilov]

Created attachment 58127 [details]
Proposed patch.

[WebKit Review Bot]

Attachment 58127 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebKit/chromium/ChangeLog:5:  One or more unexpected \r (^M) found; better to use only a \n  [whitespace/carriage_return] [1]
Suppressing further [whitespace/carriage_return] reports for this file.
Total errors found: 1 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Pavel Podivilov]

Created attachment 58128 [details]
Proposed patch.

[Yury Semikhatsky]

Comment on attachment 58128 [details]
Proposed patch.

WebKit/chromium/src/WebDevToolsAgentImpl.cpp:465
 +      WebCString debuggerScriptJs = m_client->debuggerScriptSource();
Please surround it with #if ENABLE(V8_SCRIPT_DEBUG_SERVER) guard, otherwise looks good.

[Yury Semikhatsky]

Comment on attachment 58128 [details]
Proposed patch.

DebuggerScript.js should be excluded from devtools.html script list. r- for that

[Pavel Podivilov]

Created attachment 58230 [details]
Proposed patch.

[WebKit Review Bot]

Attachment 58230 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebCore/ChangeLog:2:  One or more unexpected \r (^M) found; better to use only a \n  [whitespace/carriage_return] [1]
Suppressing further [whitespace/carriage_return] reports for this file.
WebKit/chromium/ChangeLog:3:  One or more unexpected \r (^M) found; better to use only a \n  [whitespace/carriage_return] [1]
Suppressing further [whitespace/carriage_return] reports for this file.
Total errors found: 11 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Pavel Podivilov]

Created attachment 58231 [details]
Proposed patch.

[WebKit Review Bot]

Attachment 58231 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebCore/ChangeLog:2:  One or more unexpected \r (^M) found; better to use only a \n  [whitespace/carriage_return] [1]
Suppressing further [whitespace/carriage_return] reports for this file.
WebKit/chromium/ChangeLog:3:  One or more unexpected \r (^M) found; better to use only a \n  [whitespace/carriage_return] [1]
Suppressing further [whitespace/carriage_return] reports for this file.
Total errors found: 11 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Pavel Podivilov]

Created attachment 58232 [details]
Proposed patch.

[Yury Semikhatsky]

Comment on attachment 58232 [details]
Proposed patch.

WebCore/inspector/InspectorController.cpp:439
 +          enableDebuggerFromFrontend(false);
This will cause all parsed scripts to be pushed to the frontend along with their content. It may be quite expensive and currently we don't send the sources until ScriptsPanel is shown. We should come up with something smarter here.

[Yury Semikhatsky]

(In reply to comment #11)
> (From update of attachment 58232 [details])
> WebCore/inspector/InspectorController.cpp:439
>  +          enableDebuggerFromFrontend(false);
> This will cause all parsed scripts to be pushed to the frontend along with their content. It may be quite expensive and currently we don't send the sources until ScriptsPanel is shown. We should come up with something smarter here.

Please file a bug on this and put it as a FIXME at that line. We'll fix this in a separate change.

[Pavel Podivilov]

Created attachment 58243 [details]
Proposed patch.

[WebKit Review Bot]

Attachment 58243 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebCore/inspector/InspectorController.cpp:442:  An else should appear on the same line as the preceding }  [whitespace/newline] [4]
Total errors found: 1 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Pavel Podivilov]

Created attachment 58244 [details]
Proposed patch.

[Yury Semikhatsky]

Comment on attachment 58244 [details]
Proposed patch.

Clearing flags on attachment: 58244

Committed r60893: <http://trac.webkit.org/changeset/60893>

[Yury Semikhatsky]

All reviewed patches have been landed.  Closing bug.

[WebKit Review Bot]

http://trac.webkit.org/changeset/60893 might have broken GTK Linux 64-bit Debug