Adding new type to OwnPtrCommon needlessly causes all ports to do full rebuilds. Change OwnPtrCommon to include platform-specific headers to avoid all ports rebuilds.
Created attachment 58106 [details] Patch
Comment on attachment 58106 [details] Patch Don't you need to make some changes to a build system?
(In reply to comment #2) > (From update of attachment 58106 [details]) > Don't you need to make some changes to a build system? I wanted to check it with Windows build bot.
It will probably build on Windows without being added to the build system, but you probably want to add them anyway. You can just look at the vcproj files and infer the structure.
Created attachment 58110 [details] Revised patch Add OwnPtrWin.h to WTF.vcproj.
Comment on attachment 58110 [details] Revised patch Great! Thanks.
Comment on attachment 58110 [details] Revised patch Clearing flags on attachment: 58110 Committed r60830: <http://trac.webkit.org/changeset/60830>
All reviewed patches have been landed. Closing bug.
Thanks for the patch! The guards possibly should have been WTF_OwnPtrBrew_h instead of just OwnPtrBrew_h. I'm not entirely sure of the convention.
(In reply to comment #9) > Thanks for the patch! > > The guards possibly should have been WTF_OwnPtrBrew_h instead of just OwnPtrBrew_h. I'm not entirely sure of the convention. I originally used WTF_OwnPtrBrew_h, but check-webkit-style complained about it.
This seems to have broken the Windows build: http://build.webkit.org/builders/Windows%20Debug%20(Build)/builds/16866/steps/compile-webkit/logs/stdio QTMovieGWorld.cpp c:\cygwin\home\buildbot\slave\win-debug\build\webkitbuild\include\private\javascriptcore\OwnPtrCommon.h(45) : fatal error C1083: Cannot open include file: 'wtf/win/OwnPtrWin.h': No such file or directory
Created attachment 58234 [details] Revised patch (build fix) New patch with build fix. It took me several hours to setup Windows build environment :(
Comment on attachment 58234 [details] Revised patch (build fix) Thanks. Sorry the Windows build is so painful.
It seems this patch is in the commit-queue forever. Eric, can you look at this?
The commit-queue has been blocked for nearly 5 days due to various problems. First was the Gtk builders being broken, then a hyphenate test, and then finally some cq issues on teh bot itself today. it's running now,b ut the tree is currently red. Once the tree turns green again I expect the queue will clear quickly.
This bug is closed. Is it suppposd to be open? The commit-queue doesn't land patches from closed bugs.
Reopen the bug as we still have a pending patch.
Comment on attachment 58234 [details] Revised patch (build fix) Clearing flags on attachment: 58234 Committed r61842: <http://trac.webkit.org/changeset/61842>
Reopen, because it was rolled out by http://trac.webkit.org/changeset/61847
Is there any update for this bug?
To me this doesn’t seem important to do. Modifying OwnPtrCommon doesn’t seem like a frequent enough operation to be worth optimizing. Maybe I am missing something.
OwnPtr isn't part of the code base any longer.