Bug 40261 - [Qt] SmartReplaceQt.cpp has coding-style errors
Summary: [Qt] SmartReplaceQt.cpp has coding-style errors
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P5 Trivial
Assignee: Nobody
URL:
Keywords: EasyFix, Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2010-06-07 13:07 PDT by Anders Bakken
Modified: 2011-04-06 01:53 PDT (History)
6 users (show)

See Also:

Attachments
Patch (3.05 KB, patch)
2010-06-07 13:07 PDT, Anders Bakken 		levin: review-
Details | Formatted Diff | Diff
Fixing previous patch submitted by Anders Bakken to fix the coding-style on SmartReplaceQt.cpp (3.00 KB, patch)
2011-04-05 09:13 PDT, Rafael Brandao 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Bakken 2010-06-07 13:07:16 PDT 
[Qt] SmartReplaceQt.cpp has coding-style errors
Comment 1 Anders Bakken 2010-06-07 13:07:47 PDT 
Created attachment 58079 [details]
Patch
Comment 2 David Levin 2010-06-09 09:14:16 PDT 
Comment on attachment 58079 [details]
Patch

>+ No new tests. (OOPS!)

:(
Comment 3 Jędrzej Nowacki 2010-06-15 04:37:42 PDT 
I don't like it, it destroys history of changes. I think it is not in the we work with webkit, general policy is that code shouldn't be changed only for a style reason.

Personally I preferred previous version, but you are right, it is not webkit style. If you do want to make a fix, please change comments, they should be full phrases with point at the end.

(In reply to comment #2)
> (From update of attachment 58079 [details])
> >+ No new tests. (OOPS!)
> :(
The change don't need tests.
Comment 4 Rafael Brandao 2011-04-05 09:13:40 PDT 
Created attachment 88247 [details]
Fixing previous patch submitted by Anders Bakken to fix the coding-style on SmartReplaceQt.cpp
Comment 5 WebKit Commit Bot 2011-04-06 00:46:43 PDT 
Comment on attachment 88247 [details]
Fixing previous patch submitted by Anders Bakken to fix the coding-style on SmartReplaceQt.cpp

Clearing flags on attachment: 88247

Committed r83029: <http://trac.webkit.org/changeset/83029>
Comment 6 WebKit Commit Bot 2011-04-06 00:46:48 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 WebKit Commit Bot 2011-04-06 00:56:51 PDT 
The commit-queue encountered the following flaky tests while processing attachment 88247 [details]:

animations/suspend-resume-animation.html bug 48161 (author: cmarrin@apple.com)
The commit-queue is continuing to process your patch.
Comment 8 WebKit Review Bot 2011-04-06 01:53:07 PDT 
http://trac.webkit.org/changeset/83029 might have broken GTK Linux 32-bit Debug