Bug 40261 – [Qt] SmartReplaceQt.cpp has coding-style errors

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Anders Bakken]

[Qt] SmartReplaceQt.cpp has coding-style errors

[Anders Bakken]

Created attachment 58079 [details]
Patch

[David Levin]

Comment on attachment 58079 [details]
Patch

>+ No new tests. (OOPS!)

:(

[Jędrzej Nowacki]

I don't like it, it destroys history of changes. I think it is not in the we work with webkit, general policy is that code shouldn't be changed only for a style reason.

Personally I preferred previous version, but you are right, it is not webkit style. If you do want to make a fix, please change comments, they should be full phrases with point at the end.

(In reply to comment #2)
> (From update of attachment 58079 [details])
> >+ No new tests. (OOPS!)
> :(
The change don't need tests.

[Rafael Brandao]

Created attachment 88247 [details]
Fixing previous patch submitted by Anders Bakken to fix the coding-style on SmartReplaceQt.cpp

[WebKit Commit Bot]

Comment on attachment 88247 [details]
Fixing previous patch submitted by Anders Bakken to fix the coding-style on SmartReplaceQt.cpp

Clearing flags on attachment: 88247

Committed r83029: <http://trac.webkit.org/changeset/83029>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 88247 [details]:

animations/suspend-resume-animation.html bug 48161 (author: [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Review Bot]

http://trac.webkit.org/changeset/83029 might have broken GTK Linux 32-bit Debug