Bug 40259 - [Qt] EventHandlerQt.cpp has coding-style errors
Summary: [Qt] EventHandlerQt.cpp has coding-style errors
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords: Qt
Depends on:
Blocks:
 
Reported: 2010-06-07 13:03 PDT by Anders Bakken
Modified: 2010-06-12 21:47 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.67 KB, patch)
2010-06-07 13:03 PDT, Anders Bakken 		no flags Details | Formatted Diff | Diff
Patch (1.67 KB, patch)
2010-06-08 10:37 PDT, Anders Bakken 		no flags Details | Formatted Diff | Diff
Patch (1.68 KB, patch)
2010-06-08 10:55 PDT, Anders Bakken 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Bakken 2010-06-07 13:03:21 PDT 
[Qt] EventHandlerQt.cpp has coding-style errors
Comment 1 Anders Bakken 2010-06-07 13:03:59 PDT 
Created attachment 58077 [details]
Patch
Comment 2 Laszlo Gombos 2010-06-08 10:34:36 PDT 
Comment on attachment 58077 [details]
Patch

Please remove "(OOPS!)" from the ChangeLog and perhaps mention why there is no new tests (e.g. "no new functionality" or "style change only").

Also I saw that you have quite a few changes up for review (with similar problems). I think you can combine some of these into a single patch (if all they do is style fixes for QtWebKit).

Thanks.
Comment 3 Anders Bakken 2010-06-08 10:37:30 PDT 
Created attachment 58157 [details]
Patch
Comment 4 WebKit Review Bot 2010-06-08 10:41:16 PDT 
Attachment 58157 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebCore/ChangeLog:8:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Anders Bakken 2010-06-08 10:55:05 PDT 
Created attachment 58159 [details]
Patch
Comment 6 WebKit Commit Bot 2010-06-12 21:47:08 PDT 
Comment on attachment 58159 [details]
Patch

Clearing flags on attachment: 58159

Committed r61078: <http://trac.webkit.org/changeset/61078>
Comment 7 WebKit Commit Bot 2010-06-12 21:47:12 PDT 
All reviewed patches have been landed.  Closing bug.