Bug 40258 - [Qt] DragControllerQt.cpp has coding-style errors
Summary: [Qt] DragControllerQt.cpp has coding-style errors
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P5 Trivial
Assignee: Nobody
URL:
Keywords: EasyFix, Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2010-06-07 13:01 PDT by Anders Bakken
Modified: 2011-04-05 20:56 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.16 KB, patch)
2010-06-07 13:01 PDT, Anders Bakken 		levin: review-
Details | Formatted Diff | Diff
Fixing previous patch submitted by Anders Bakken to fix the coding-style on DragControllerQt.cpp (1.12 KB, patch)
2011-04-05 09:38 PDT, Rafael Brandao 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Bakken 2010-06-07 13:01:12 PDT 
[Qt] DragControllerQt.cpp has coding-style errors
Comment 1 Anders Bakken 2010-06-07 13:01:36 PDT 
Created attachment 58076 [details]
Patch
Comment 2 David Levin 2010-06-09 09:15:18 PDT 
Comment on attachment 58076 [details]
Patch

>+ No new tests. (OOPS!)
:(
Comment 3 Jędrzej Nowacki 2010-06-15 06:30:08 PDT 
WebCore/ChangeLog:8
 +          No new tests. (OOPS!)
You should remove this line.

WebCore/page/qt/DragControllerQt.cpp:53
 +      // FIXME: This logic is incomplete
'.' at the end.
Comment 4 Rafael Brandao 2011-04-05 09:38:54 PDT 
Created attachment 88255 [details]
Fixing previous patch submitted by Anders Bakken to fix the coding-style on DragControllerQt.cpp
Comment 5 WebKit Commit Bot 2011-04-05 20:56:51 PDT 
Comment on attachment 88255 [details]
Fixing previous patch submitted by Anders Bakken to fix the coding-style on DragControllerQt.cpp

Clearing flags on attachment: 88255

Committed r83014: <http://trac.webkit.org/changeset/83014>
Comment 6 WebKit Commit Bot 2011-04-05 20:56:55 PDT 
All reviewed patches have been landed.  Closing bug.