Adds IndexedDB's KeyRange.
Created attachment 58065 [details] Patch
Comment on attachment 58065 [details] Patch Looking pretty good.... WebCore/storage/IndexedDatabaseRequest.idl:32 + IDBKeyRange makeSingleKeyRange(in SerializedScriptValue value); Use [Optional] after the "in" for all the optional args and get rid of the comment documenting it. Put them all on the same line. WebCore/storage/IndexedDatabaseRequest.h:60 + PassRefPtr<IDBKeyRange> makeBoundKeyRange(PassRefPtr<SerializedScriptValue> left, PassRefPtr<SerializedScriptValue> right, bool openLeft, bool openRight); For the optional parameters, put the default here (i.e. |bool open = false|). WebCore/storage/IDBKeyRange.idl:31 + const unsigned short SINGLE = 0; Add "// Keep in sync with what's in the .h file." WebCore/storage/IDBKeyRange.h:57 + PassRefPtr<IDBAny> left() { return m_left; } const for all 3 WebCore/storage/IndexedDatabaseRequest.cpp:65 + SerializedScriptValue* rawValue = value.releaseRef(); Now is a good time to read http://webkit.org/coding/RefPtr.html again. PassRefPtr<IDBKeyRange> IndexedDatabaseRequest::makeSingleKeyRange(PassRefPtr<SerializedScriptValue> prpValue) { RefPtr<SerializedScriptValue> value = prpValue;
Created attachment 58132 [details] Patch
(In reply to comment #2) > (From update of attachment 58065 [details]) > Looking pretty good.... thanks Jeremy! all comments addressed, another look please? > > WebCore/storage/IndexedDatabaseRequest.idl:32 > + IDBKeyRange makeSingleKeyRange(in SerializedScriptValue value); > Use [Optional] after the "in" for all the optional args and get rid of the comment documenting it. Put them all on the same line. done. > > WebCore/storage/IndexedDatabaseRequest.h:60 > + PassRefPtr<IDBKeyRange> makeBoundKeyRange(PassRefPtr<SerializedScriptValue> left, PassRefPtr<SerializedScriptValue> right, bool openLeft, bool openRight); > For the optional parameters, put the default here (i.e. |bool open = false|). done. > > WebCore/storage/IDBKeyRange.idl:31 > + const unsigned short SINGLE = 0; > Add "// Keep in sync with what's in the .h file." done. > > WebCore/storage/IDBKeyRange.h:57 > + PassRefPtr<IDBAny> left() { return m_left; } > const for all 3 done. > > WebCore/storage/IndexedDatabaseRequest.cpp:65 > + SerializedScriptValue* rawValue = value.releaseRef(); > Now is a good time to read http://webkit.org/coding/RefPtr.html again. > > PassRefPtr<IDBKeyRange> IndexedDatabaseRequest::makeSingleKeyRange(PassRefPtr<SerializedScriptValue> prpValue) { > RefPtr<SerializedScriptValue> value = prpValue; thanks for the refresher! done.
Comment on attachment 58132 [details] Patch You need to add the KeyRange.h/cpp to Android.mk + CMakeLists.txt the idl's need to be added to derivedSrouces make and all in one files. You also forgot the xcode project + visual studio.WebCore/storage/IDBKeyRange.cpp:13 + * 3. Neither the name of Apple Computer, Inc. ("Apple") nor the names of Copy the license from one of the other IDB files...the 2 clause license without "Apple Computer" is the latest. WebCore/storage/IDBKeyRange.cpp:40 + : m_left(IDBAny::create()), m_right(IDBAny::create()), m_flags(flags) separate onto their own lines.
Created attachment 58145 [details] Patch
Comment on attachment 58145 [details] Patch WebCore/storage/IDBKeyRange.cpp:38 + m_right(IDBAny::create()), commas at beginning not end
Created attachment 58147 [details] Patch
Comment on attachment 58147 [details] Patch my r+ cq- meant that I was fine with the last patch but just wanted you to fix it upon landing.
Comment on attachment 58147 [details] Patch Rejecting patch 58147 from commit-queue. Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Jeremy Orlow', u'--force']" exit_code: 1 Last 500 characters of output: ). Hunk #4 succeeded at 14509 (offset 12 lines). Hunk #5 FAILED at 19460. Hunk #6 FAILED at 21763. 2 out of 6 hunks FAILED -- saving rejects to file WebCore/WebCore.xcodeproj/project.pbxproj.rej patching file WebCore/storage/IDBKeyRange.cpp patching file WebCore/storage/IDBKeyRange.h patching file WebCore/storage/IDBKeyRange.idl patching file WebCore/storage/IndexedDatabaseRequest.cpp patching file WebCore/storage/IndexedDatabaseRequest.h patching file WebCore/storage/IndexedDatabaseRequest.idl Full output: http://webkit-commit-queue.appspot.com/results/3190120
Created attachment 58355 [details] Patch
Comment on attachment 58355 [details] Patch Rubber stamped because you already had a r+ from me.
Comment on attachment 58355 [details] Patch Rejecting patch 58355 from commit-queue. Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Jeremy Orlow', u'--force']" exit_code: 1 Last 500 characters of output: 55. Hunk #4 succeeded at 14519 (offset 4 lines). Hunk #5 FAILED at 19477. Hunk #6 FAILED at 21783. 3 out of 6 hunks FAILED -- saving rejects to file WebCore/WebCore.xcodeproj/project.pbxproj.rej patching file WebCore/storage/IDBKeyRange.cpp patching file WebCore/storage/IDBKeyRange.h patching file WebCore/storage/IDBKeyRange.idl patching file WebCore/storage/IndexedDatabaseRequest.cpp patching file WebCore/storage/IndexedDatabaseRequest.h patching file WebCore/storage/IndexedDatabaseRequest.idl Full output: http://webkit-commit-queue.appspot.com/results/3231145
Committed r61120: <http://trac.webkit.org/changeset/61120>