Bug 40237 - [Qt] QtWebKit exports WebCore symbols
Summary: [Qt] QtWebKit exports WebCore symbols
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P3 Normal
Assignee: Nobody
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2010-06-07 09:17 PDT by Felix Geyer
Modified: 2014-02-03 03:06 PST (History)
2 users (show)

See Also:


Attachments
Patch to reduce visibility similar to the JavaScriptCore commit (648 bytes, patch)
2010-06-07 09:17 PDT, Felix Geyer
eric: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Felix Geyer 2010-06-07 09:17:58 PDT
Created attachment 58036 [details]
Patch to reduce visibility similar to the JavaScriptCore commit

QtWebKit exports the WebCore symbols when building as a standalone package.

Previously the JavaScriptCore symbols were exported too.
This has been fixed by this commit:
http://trac.webkit.org/changeset/58100/trunk/JavaScriptCore/JavaScriptCore.pro

The same should be done in WebCore.
Comment 1 Jocelyn Turcotte 2010-06-10 03:32:50 PDT
Looks good to me.

The CONFIG(standalone_package) condition should clearly be removed since we will start getting releases separated from Qt.

If you want a reviewer to look at your patch you should set the review flag of the attachment to '?' (and the commit queue flag to '?' if you want it to be landed automatically)
Comment 2 Eric Seidel (no email) 2010-06-12 19:11:01 PDT
Comment on attachment 58036 [details]
Patch to reduce visibility similar to the JavaScriptCore commit

Please generate the patch from a WebKit checkout, and include a ChangeLog per our contribution guidelines:
http://webkit.org/coding/contributing.html

webkit-patch upload
is one script which can help you make sure you're following the guildes.
Comment 3 Jocelyn Turcotte 2014-02-03 03:06:49 PST
=== Bulk closing of Qt bugs ===

If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary.

If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines.