Bug 40226 - [BREWMP] Add PopupMenu implementation
Summary: [BREWMP] Add PopupMenu implementation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 33564
  Show dependency treegraph
 
Reported: 2010-06-07 04:21 PDT by Kwang Yul Seo
Modified: 2010-06-23 18:19 PDT (History)
3 users (show)

See Also:


Attachments
Patch (6.15 KB, patch)
2010-06-07 04:51 PDT, Kwang Yul Seo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kwang Yul Seo 2010-06-07 04:21:37 PDT
Delegate PopupMenu handling to ChromeClientBrew.
Comment 1 Kwang Yul Seo 2010-06-07 04:51:53 PDT
Created attachment 58016 [details]
Patch

Add methods to create and destory PopupMenu to ChromeClientBrew and delegate PopupMenu handling to WebKit API layer.
Comment 2 Kent Tamura 2010-06-20 03:46:53 PDT
Comment on attachment 58016 [details]
Patch

WebCore/page/brew/ChromeClientBrew.h:43
 +  class ChromeClientBrew : public ChromeClient {
ChromeClient[Platform] is usually used as an implementation of ChromeClient.  (See WebKit/*/WebCoreSupport/ChromeClinet*)
Are you determined to go on your own way?  I know this follows Chromium code.
Comment 3 Kwang Yul Seo 2010-06-22 11:24:38 PDT
(In reply to comment #2)
> (From update of attachment 58016 [details])
> WebCore/page/brew/ChromeClientBrew.h:43
>  +  class ChromeClientBrew : public ChromeClient {
> ChromeClient[Platform] is usually used as an implementation of ChromeClient.  (See WebKit/*/WebCoreSupport/ChromeClinet*)
> Are you determined to go on your own way?  I know this follows Chromium code.

Yes, I followed the Chromium code because I want to delegate PopupMenu to the WebKit API layer.
Comment 4 Kent Tamura 2010-06-22 18:58:45 PDT
Comment on attachment 58016 [details]
Patch

OK.
Comment 5 WebKit Commit Bot 2010-06-23 17:33:29 PDT
Comment on attachment 58016 [details]
Patch

Rejecting patch 58016 from commit-queue.

Failed to run "[u'git', u'svn', u'dcommit']" exit_code: 1
Last 500 characters of output:
0 040000 0a86c46f41919178f80a6ab366cc7b24646dfe17 76397f755d659875386414a5f420904404342d1a M	LayoutTests
:040000 040000 4c049aff9073c316b2087758d9d939dc7400854d ff6f0f70de0f7096cbb2478008eda3b637007e27 M	WebKit2
First, rewinding head to replay your work on top of it...
error: Untracked working tree file 'LayoutTests/fast/dom/beforeload/remove-bad-object-in-beforeload-listener-expected.txt' would be overwritten by merge.
could not detach HEAD
rebase refs/remotes/trunk: command returned error: 1


Full output: http://webkit-commit-queue.appspot.com/results/3332693
Comment 6 Kwang Yul Seo 2010-06-23 17:35:34 PDT
(In reply to comment #5)
> (From update of attachment 58016 [details])
> Rejecting patch 58016 from commit-queue.
> 
> Failed to run "[u'git', u'svn', u'dcommit']" exit_code: 1
> Last 500 characters of output:
> 0 040000 0a86c46f41919178f80a6ab366cc7b24646dfe17 76397f755d659875386414a5f420904404342d1a M    LayoutTests
> :040000 040000 4c049aff9073c316b2087758d9d939dc7400854d ff6f0f70de0f7096cbb2478008eda3b637007e27 M    WebKit2
> First, rewinding head to replay your work on top of it...
> error: Untracked working tree file 'LayoutTests/fast/dom/beforeload/remove-bad-object-in-beforeload-listener-expected.txt' would be overwritten by merge.
> could not detach HEAD
> rebase refs/remotes/trunk: command returned error: 1
> 
> 
> Full output: http://webkit-commit-queue.appspot.com/results/3332693

What's this message? Some problem with git?
Comment 7 Kent Tamura 2010-06-23 18:19:42 PDT
It seems something was wrong with commit-queue.
Anyway, the patch was landed as http://trac.webkit.org/changeset/61722