WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
40226
[BREWMP] Add PopupMenu implementation
https://bugs.webkit.org/show_bug.cgi?id=40226
Summary
[BREWMP] Add PopupMenu implementation
Kwang Yul Seo
Reported
2010-06-07 04:21:37 PDT
Delegate PopupMenu handling to ChromeClientBrew.
Attachments
Patch
(6.15 KB, patch)
2010-06-07 04:51 PDT
,
Kwang Yul Seo
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Kwang Yul Seo
Comment 1
2010-06-07 04:51:53 PDT
Created
attachment 58016
[details]
Patch Add methods to create and destory PopupMenu to ChromeClientBrew and delegate PopupMenu handling to WebKit API layer.
Kent Tamura
Comment 2
2010-06-20 03:46:53 PDT
Comment on
attachment 58016
[details]
Patch WebCore/page/brew/ChromeClientBrew.h:43 + class ChromeClientBrew : public ChromeClient { ChromeClient[Platform] is usually used as an implementation of ChromeClient. (See WebKit/*/WebCoreSupport/ChromeClinet*) Are you determined to go on your own way? I know this follows Chromium code.
Kwang Yul Seo
Comment 3
2010-06-22 11:24:38 PDT
(In reply to
comment #2
)
> (From update of
attachment 58016
[details]
) > WebCore/page/brew/ChromeClientBrew.h:43 > + class ChromeClientBrew : public ChromeClient { > ChromeClient[Platform] is usually used as an implementation of ChromeClient. (See WebKit/*/WebCoreSupport/ChromeClinet*) > Are you determined to go on your own way? I know this follows Chromium code.
Yes, I followed the Chromium code because I want to delegate PopupMenu to the WebKit API layer.
Kent Tamura
Comment 4
2010-06-22 18:58:45 PDT
Comment on
attachment 58016
[details]
Patch OK.
WebKit Commit Bot
Comment 5
2010-06-23 17:33:29 PDT
Comment on
attachment 58016
[details]
Patch Rejecting patch 58016 from commit-queue. Failed to run "[u'git', u'svn', u'dcommit']" exit_code: 1 Last 500 characters of output: 0 040000 0a86c46f41919178f80a6ab366cc7b24646dfe17 76397f755d659875386414a5f420904404342d1a M LayoutTests :040000 040000 4c049aff9073c316b2087758d9d939dc7400854d ff6f0f70de0f7096cbb2478008eda3b637007e27 M WebKit2 First, rewinding head to replay your work on top of it... error: Untracked working tree file 'LayoutTests/fast/dom/beforeload/remove-bad-object-in-beforeload-listener-expected.txt' would be overwritten by merge. could not detach HEAD rebase refs/remotes/trunk: command returned error: 1 Full output:
http://webkit-commit-queue.appspot.com/results/3332693
Kwang Yul Seo
Comment 6
2010-06-23 17:35:34 PDT
(In reply to
comment #5
)
> (From update of
attachment 58016
[details]
) > Rejecting patch 58016 from commit-queue. > > Failed to run "[u'git', u'svn', u'dcommit']" exit_code: 1 > Last 500 characters of output: > 0 040000 0a86c46f41919178f80a6ab366cc7b24646dfe17 76397f755d659875386414a5f420904404342d1a M LayoutTests > :040000 040000 4c049aff9073c316b2087758d9d939dc7400854d ff6f0f70de0f7096cbb2478008eda3b637007e27 M WebKit2 > First, rewinding head to replay your work on top of it... > error: Untracked working tree file 'LayoutTests/fast/dom/beforeload/remove-bad-object-in-beforeload-listener-expected.txt' would be overwritten by merge. > could not detach HEAD > rebase refs/remotes/trunk: command returned error: 1 > > > Full output:
http://webkit-commit-queue.appspot.com/results/3332693
What's this message? Some problem with git?
Kent Tamura
Comment 7
2010-06-23 18:19:42 PDT
It seems something was wrong with commit-queue. Anyway, the patch was landed as
http://trac.webkit.org/changeset/61722
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug