Delegate PopupMenu handling to ChromeClientBrew.
Created attachment 58016 [details] Patch Add methods to create and destory PopupMenu to ChromeClientBrew and delegate PopupMenu handling to WebKit API layer.
Comment on attachment 58016 [details] Patch WebCore/page/brew/ChromeClientBrew.h:43 + class ChromeClientBrew : public ChromeClient { ChromeClient[Platform] is usually used as an implementation of ChromeClient. (See WebKit/*/WebCoreSupport/ChromeClinet*) Are you determined to go on your own way? I know this follows Chromium code.
(In reply to comment #2) > (From update of attachment 58016 [details]) > WebCore/page/brew/ChromeClientBrew.h:43 > + class ChromeClientBrew : public ChromeClient { > ChromeClient[Platform] is usually used as an implementation of ChromeClient. (See WebKit/*/WebCoreSupport/ChromeClinet*) > Are you determined to go on your own way? I know this follows Chromium code. Yes, I followed the Chromium code because I want to delegate PopupMenu to the WebKit API layer.
Comment on attachment 58016 [details] Patch OK.
Comment on attachment 58016 [details] Patch Rejecting patch 58016 from commit-queue. Failed to run "[u'git', u'svn', u'dcommit']" exit_code: 1 Last 500 characters of output: 0 040000 0a86c46f41919178f80a6ab366cc7b24646dfe17 76397f755d659875386414a5f420904404342d1a M LayoutTests :040000 040000 4c049aff9073c316b2087758d9d939dc7400854d ff6f0f70de0f7096cbb2478008eda3b637007e27 M WebKit2 First, rewinding head to replay your work on top of it... error: Untracked working tree file 'LayoutTests/fast/dom/beforeload/remove-bad-object-in-beforeload-listener-expected.txt' would be overwritten by merge. could not detach HEAD rebase refs/remotes/trunk: command returned error: 1 Full output: http://webkit-commit-queue.appspot.com/results/3332693
(In reply to comment #5) > (From update of attachment 58016 [details]) > Rejecting patch 58016 from commit-queue. > > Failed to run "[u'git', u'svn', u'dcommit']" exit_code: 1 > Last 500 characters of output: > 0 040000 0a86c46f41919178f80a6ab366cc7b24646dfe17 76397f755d659875386414a5f420904404342d1a M LayoutTests > :040000 040000 4c049aff9073c316b2087758d9d939dc7400854d ff6f0f70de0f7096cbb2478008eda3b637007e27 M WebKit2 > First, rewinding head to replay your work on top of it... > error: Untracked working tree file 'LayoutTests/fast/dom/beforeload/remove-bad-object-in-beforeload-listener-expected.txt' would be overwritten by merge. > could not detach HEAD > rebase refs/remotes/trunk: command returned error: 1 > > > Full output: http://webkit-commit-queue.appspot.com/results/3332693 What's this message? Some problem with git?
It seems something was wrong with commit-queue. Anyway, the patch was landed as http://trac.webkit.org/changeset/61722