fileSystemRepresentation and filenameFromString do the same thing. Unify them into filenameFromString.
Created attachment 57960 [details] Patch
Comment on attachment 57960 [details] Patch filenameFromString() is poorly named and unused/unimplemented on many platforms. It doesn't even return a file name. I suggest removing this function instead.
Created attachment 57989 [details] Revised patch Okay. Remove filenameFromString instead.
Attachment 57989 [details] did not build on gtk: Build output: http://webkit-commit-queue.appspot.com/results/3124176
Created attachment 57991 [details] Revised patch (GTK build fix) GTK build fix.
Comment on attachment 57991 [details] Revised patch (GTK build fix) Looks good to me as far as most ports are concerned, but I don't understand what Gtk/Efl were doing here. Maybe someone working on Gtk should take a look, too. - char* filename = g_uri_unescape_string(string.utf8().data(), 0); + char* filename = g_uri_unescape_string(path.utf8().data(), 0);
(In reply to comment #6) > (From update of attachment 57991 [details]) > Looks good to me as far as most ports are concerned, but I don't understand what Gtk/Efl were doing here. Maybe someone working on Gtk should take a look, too. > > - char* filename = g_uri_unescape_string(string.utf8().data(), 0); > + char* filename = g_uri_unescape_string(path.utf8().data(), 0); We can see the reason from the following ChangeLog. 2008-10-15 Marco Barisione <marco.barisione@collabora.co.uk> Reviewed by Holger Freyther. http://bugs.webkit.org/show_bug.cgi?id=20664 [GTK] File names are not always encodable in UTF-8 On Linux file names are just raw data and cannot always be directly encoded in UTF-8 or in any other encodings, so we escape them before storing the file name in a String and unescape them before passing them to native functions handling files.
Comment on attachment 57991 [details] Revised patch (GTK build fix) Clearing flags on attachment: 57991 Committed r61077: <http://trac.webkit.org/changeset/61077>
All reviewed patches have been landed. Closing bug.