Bug 40194 - AX: support helpText() in DumpRenderTree
Summary: AX: support helpText() in DumpRenderTree
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2010-06-04 18:05 PDT by chris fleizach
Modified: 2013-11-12 11:45 PST (History)
11 users (show)

See Also:


Attachments
Patch. (4.10 KB, patch)
2013-11-11 09:47 PST, Samuel White
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description chris fleizach 2010-06-04 18:05:13 PDT
that way you can uncomment out accessibility/aria-help.html from the skipped test lists
Comment 1 Samuel White 2013-09-30 13:04:54 PDT
<rdar://problem/15113997>
Comment 2 Samuel White 2013-11-11 09:47:58 PST
Created attachment 216584 [details]
Patch.
Comment 3 WebKit Commit Bot 2013-11-11 13:07:11 PST
Comment on attachment 216584 [details]
Patch.

Clearing flags on attachment: 216584

Committed r159067: <http://trac.webkit.org/changeset/159067>
Comment 4 WebKit Commit Bot 2013-11-11 13:07:14 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Michael Saboff 2013-11-12 11:13:22 PST
This test has been failing 100% of the time since the move, on all platforms.
Comment 6 Tim Horton 2013-11-12 11:13:59 PST
(In reply to comment #5)
> This test has been failing 100% of the time since the move, on all platforms.

Sorry, that was me, machine was still logged in as msaboff.
Comment 7 chris fleizach 2013-11-12 11:14:06 PST
Comment on attachment 216584 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=216584&action=review

> LayoutTests/accessibility/aria-help.html:4
> +<script src="../../../resources/js-test-pre.js"></script>

this lines need to be updated to be ../resources
Comment 8 Tim Horton 2013-11-12 11:16:08 PST
(In reply to comment #7)
> (From update of attachment 216584 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=216584&action=review
> 
> > LayoutTests/accessibility/aria-help.html:4
> > +<script src="../../../resources/js-test-pre.js"></script>
> 
> this lines need to be updated to be ../resources

Will do!
Comment 9 Tim Horton 2013-11-12 11:19:22 PST
Theoretically fixed in http://trac.webkit.org/changeset/159128
Comment 10 Samuel White 2013-11-12 11:35:56 PST
(In reply to comment #9)
> Theoretically fixed in http://trac.webkit.org/changeset/159128

Thanks Tim.
Comment 11 Samuel White 2013-11-12 11:37:20 PST
Chris, any idea why this didn't get caught by the bots? The mac platform results should have failed for aria-help.html.
Comment 12 Tim Horton 2013-11-12 11:45:06 PST
(In reply to comment #11)
> Chris, any idea why this didn't get caught by the bots? The mac platform results should have failed for aria-help.html.

They certainly caught it when it was landed. Not sure why EWS didn't notice...