Bug 40169 - Android makefiles always rebuild stuff
Summary: Android makefiles always rebuild stuff
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-04 08:57 PDT by Leon Clarke
Modified: 2010-06-07 05:33 PDT (History)
3 users (show)

See Also:


Attachments
Proposed fix (1.90 KB, patch)
2010-06-04 08:58 PDT, Leon Clarke
jorlow: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
Added a changelog this time. Oops. Also the previous patch was actually missing an include directory. (2.70 KB, patch)
2010-06-07 03:44 PDT, Leon Clarke
jorlow: review+
jorlow: commit-queue-
Details | Formatted Diff | Diff
One of these days I'll get this right (2.74 KB, patch)
2010-06-07 04:01 PDT, Leon Clarke
jorlow: review+
jorlow: commit-queue-
Details | Formatted Diff | Diff
Try again (2.75 KB, patch)
2010-06-07 04:20 PDT, Leon Clarke
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Leon Clarke 2010-06-04 08:57:08 PDT
due to a tab being a set of spaces
Comment 1 Leon Clarke 2010-06-04 08:58:01 PDT
Created attachment 57885 [details]
Proposed fix
Comment 2 Jeremy Orlow 2010-06-04 09:00:36 PDT
Comment on attachment 57885 [details]
Proposed fix

Sorry!

r=me
Comment 3 WebKit Commit Bot 2010-06-04 20:27:12 PDT
Comment on attachment 57885 [details]
Proposed fix

Rejecting patch 57885 from commit-queue.

Found no modified ChangeLogs, cannot create a commit message.
All changes require a ChangeLog.  See:
http://webkit.org/coding/contributing.html
Comment 4 Leon Clarke 2010-06-07 03:44:55 PDT
Created attachment 58007 [details]
Added a changelog this time. Oops. Also the previous patch was actually missing an include directory.
Comment 5 Jeremy Orlow 2010-06-07 03:52:04 PDT
Comment on attachment 58007 [details]
Added a changelog this time. Oops. Also the previous patch was actually missing an include directory.

> Index: WebCore/ChangeLog
> ===================================================================
> --- WebCore/ChangeLog	(revision 60772)
> +++ WebCore/ChangeLog	(working copy)
> @@ -1,3 +1,13 @@
> +2010-06-07  Leon Clarke  <leonclarke@google.com>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Fix indexeddb idls in android makefile

You forgot the URL.

r=me
Comment 6 Leon Clarke 2010-06-07 04:01:02 PDT
Created attachment 58010 [details]
One of these days I'll get this right
Comment 7 WebKit Review Bot 2010-06-07 04:01:47 PDT
Attachment 58010 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebCore/ChangeLog:6:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 Jeremy Orlow 2010-06-07 04:04:50 PDT
Comment on attachment 58010 [details]
One of these days I'll get this right

> Index: WebCore/ChangeLog
> ===================================================================
> --- WebCore/ChangeLog	(revision 60772)
> +++ WebCore/ChangeLog	(working copy)
> @@ -1,3 +1,14 @@
> +2010-06-07  Leon Clarke  <leonclarke@google.com>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Fix indexeddb idls in android makefile
> +	https://bugs.webkit.org/show_bug.cgi?id=40169

Not spaced in right.  :-)
Comment 9 Leon Clarke 2010-06-07 04:20:53 PDT
Created attachment 58012 [details]
Try again
Comment 10 Jeremy Orlow 2010-06-07 04:22:43 PDT
Comment on attachment 58012 [details]
Try again

r=me
Comment 11 WebKit Commit Bot 2010-06-07 05:33:02 PDT
Comment on attachment 58012 [details]
Try again

Clearing flags on attachment: 58012

Committed r60777: <http://trac.webkit.org/changeset/60777>
Comment 12 WebKit Commit Bot 2010-06-07 05:33:08 PDT
All reviewed patches have been landed.  Closing bug.