Bug 40157 - Web Inspector: CSS style closing brace is not selectable.
Summary: Web Inspector: CSS style closing brace is not selectable.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-03 23:07 PDT by Ilya Tikhonovsky
Modified: 2010-06-11 05:48 PDT (History)
9 users (show)

See Also:

Attachments
<div>}</div> inherits -webkit-user-select: none; from the body element. I overrode it. (1.52 KB, patch)
2010-06-10 04:40 PDT, Nikita Vasilyev 		pfeldman: review-
Details | Formatted Diff | Diff
Selectable brace (932 bytes, patch)
2010-06-10 05:48 PDT, Nikita Vasilyev 		no flags Details | Formatted Diff | Diff
Selectable brace (1.28 KB, patch)
2010-06-10 06:18 PDT, Nikita Vasilyev 		pfeldman: review+
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2010-06-03 23:07:37 PDT 
%SUBJ%
Comment 1 Nikita Vasilyev 2010-06-10 04:40:32 PDT 
Created attachment 58363 [details]
<div>}</div> inherits -webkit-user-select: none; from the body element. I overrode it.
Comment 2 Pavel Feldman 2010-06-10 05:00:32 PDT 
Comment on attachment 58363 [details]
<div>}</div> inherits -webkit-user-select: none; from the body element. I overrode it.

WebCore/inspector/front-end/inspector.css:3981
 +  .styles-selector, .close-brace {
I think we should add -webkit-user-select: text to .styles-section instead.
Comment 3 Nikita Vasilyev 2010-06-10 05:48:15 PDT 
Created attachment 58368 [details]
Selectable brace

Yes, it works the same.
Comment 4 Pavel Feldman 2010-06-10 05:52:16 PDT 
Comment on attachment 58368 [details]
Selectable brace

(You should have removed it from the header now that it is set on the parent element).
Comment 5 Nikita Vasilyev 2010-06-10 06:18:24 PDT 
Created attachment 58371 [details]
Selectable brace
Comment 6 Pavel Feldman 2010-06-10 06:20:00 PDT 
Comment on attachment 58371 [details]
Selectable brace

Thanks!
Comment 7 WebKit Commit Bot 2010-06-10 14:40:27 PDT 
Comment on attachment 58371 [details]
Selectable brace

Rejecting patch 58371 from commit-queue.

Unexpected failure when processing patch!  Please file a bug against webkit-patch.
Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', 'land-attachment', '--force-clean', '--build', '--non-interactive', '--ignore-builders', '--build-style=both', '--quiet', 58371, '--test', '--parent-command=commit-queue', '--no-update']" exit_code: 1
Logging in as eseidel@chromium.org...
Fetching: https://bugs.webkit.org/attachment.cgi?id=58371&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=40157&ctype=xml
Processing 1 patch from 1 bug.
Cleaning working directory
Processing patch 58371 from bug 40157.
ERROR: /Users/eseidel/Projects/CommitQueue/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).
Comment 8 Joseph Pecoraro 2010-06-11 00:16:53 PDT 
Nice!

Looks like the cq  didn't land because its missing the line to fill in for the reviewer. Using `prepare-ChangeLog` will put in the right template and prevent this error. This is missing the "Reviewed by (OOPS)" line or whatever.

I can manually add that line in and land this patch tomorrow. Or someone can beat me to it!
Comment 9 Pavel Feldman 2010-06-11 05:48:59 PDT 
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/inspector/front-end/inspector.css
Committed r61009