Bug 40146 - Geolocation needs more LayoutTests to test making callbacks to remote frames
Summary: Geolocation needs more LayoutTests to test making callbacks to remote frames
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-03 15:39 PDT by Steve Block
Modified: 2010-06-04 03:46 PDT (History)
6 users (show)

See Also:


Attachments
Patch (3.64 KB, patch)
2010-06-04 02:43 PDT, Steve Block
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Block 2010-06-03 15:39:39 PDT
Bug 40129 added a layout test to test making a callback from a Geolocation object to a remote frame. In this case, the JavaScript call chain was initiated from the frame owning the Geolocation object. We should add a similar test where the call chain is initiated from the remote frame. See https://bugs.webkit.org/show_bug.cgi?id=40129#c8
Comment 1 Steve Block 2010-06-04 02:43:54 PDT
Created attachment 57858 [details]
Patch
Comment 2 Jeremy Orlow 2010-06-04 02:52:26 PDT
Comment on attachment 57858 [details]
Patch

r=me

If you'd like, feel free to make a patch with more than one test.
Comment 3 Steve Block 2010-06-04 02:57:52 PDT
Committed r60669: <http://trac.webkit.org/changeset/60669>
Comment 4 WebKit Review Bot 2010-06-04 03:22:38 PDT
http://trac.webkit.org/changeset/60669 might have broken GTK Linux 32-bit Release
The following changes are on the blame list:
http://trac.webkit.org/changeset/60669
http://trac.webkit.org/changeset/60670
Comment 5 Steve Block 2010-06-04 03:46:40 PDT
Comment on attachment 57858 [details]
Patch

Added callback-to-remote-context2.html to the GTK skipped list in r60672, http://trac.webkit.org/changeset/60672 and updated Bug 40153