Bug 4014 - PDF files by default load with a poor choice of sizing
Summary: PDF files by default load with a poor choice of sizing
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 412
Hardware: Mac OS X 10.4
: P2 Enhancement
Assignee: Trey Matteson
URL: http://www.copyright.gov/legislation/...
Depends on:
Reported: 2005-07-15 12:58 PDT by Trey Matteson
Modified: 2005-08-01 11:06 PDT (History)
0 users

See Also:

proposed patch (15.09 KB, patch)
2005-07-31 22:33 PDT, Trey Matteson
sullivan: review-
Details | Formatted Diff | Diff
patch corrected per review (15.21 KB, patch)
2005-08-01 10:27 PDT, Trey Matteson
sullivan: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Trey Matteson 2005-07-15 12:58:20 PDT
I feel like everytime I load a PDF file inline in Safari the next thing I do is start zooming it up so I can read 
it more easily.  I would prefer behavior more like Preview with the autoscale option on.  In this mode, the 
view is scaled to fit based onthe page length, and advancing moves the doc in whole page increments.

It turns out you can get this behavior using the PDF context menu to set continuous=off and autosize=on.  
But this is tedious to do for every PDF file I open.  Thus what I really want is either a preference for turning 
this behavior on permanently, or else for the current UI settings to be sticky.
Comment 1 John Sullivan 2005-07-15 13:21:22 PDT
I think making the UI settings sticky is a good idea. This could be implemented by adding preferences to 
WebPreferences that start out at the initial PDFKit settings. These preferences would be used whenever 
WebPDFView loads a document, and would be altered whenever the user chooses from the context menu.

Ideally pages in the back/forward list would continue to be displayed with their original settings when 
revisited in the b/f list. Also, I think that ideally reloading would not affect the settings for the displayed 
page (that is, it wouldn't reload using prefs values that had changed since it was first loaded), but getting 
this exactly right could be treated as a separate, lower-importance bug I think.
Comment 2 Trey Matteson 2005-07-20 13:41:56 PDT
I am likely to take a crack at this.
Comment 3 Trey Matteson 2005-07-31 22:33:14 PDT
Created attachment 3188 [details]
proposed patch

For this round the UI is simply that changes to the PDF viewing params are
Comment 4 John Sullivan 2005-08-01 10:22:00 PDT
Comment on attachment 3188 [details]
proposed patch

Trey and I discussed a couple of tweaks on IRC, so I'm giving this version a
Comment 5 Trey Matteson 2005-08-01 10:27:21 PDT
Created attachment 3195 [details]
patch corrected per review
Comment 6 John Sullivan 2005-08-01 10:34:03 PDT
Comment on attachment 3195 [details]
patch corrected per review

I'll check this in.
Comment 7 John Sullivan 2005-08-01 11:06:44 PDT
checked in