Bug 40131 – [GTK] Add inner-node property to WebKitHitTestResult

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Xan Lopez]

Carries the DOM node where the hit test happened.

[Xan Lopez]

Created attachment 57793 [details]
innernode.diff

Patch

[WebKit Review Bot]

Attachment 57793 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebKit/gtk/webkit/webkithittestresult.cpp:212:  Missing spaces around |  [whitespace/operators] [3]
WARNING: File exempt from style guide. Skipping: "WebKit/gtk/tests/testhittestresult.c"
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Xan Lopez]

Created attachment 57794 [details]
innernode.diff

Fix style nit.

[Shaun McCance]

Thanks, Xan. This works well for the stuff I'm doing in Yelp. What needs to be done before it can be committed?

[Gustavo Noronha (kov)]

Comment on attachment 57794 [details]
innernode.diff

 199      * The DOM node at the coordinates where the hit test
 200      * happened. Keep in mind that the node might not be
 201      * representative of the information given in the context
 202      * property, since WebKit uses a series of heuristics to figure
 203      * out that information.

I think this needs an example to be better understood. I believe this means we might not be returning an <img> node, even though the hit test result has information about the hit being in an image. I think this example, or even use the example you used in the test (innert text node vs anchor element).

[Xan Lopez]

Comment on attachment 57794 [details]
innernode.diff

Pushed with the example you suggested as r60834

[Xan Lopez]

Closing.