Created attachment 57785 [details] suggested patch There are a few things that don't work anymore but are useful for debugging: * JS_ZOMBIES doesn't compile anymore. * The dumpCallFrame function in the interpreter causes a runtime error because JSValue::description does not match the current state of JSValue * The dumpRegisters function in the interpreter is not up to date with the most recent call frame patches. * Additionally it would be nice if JSValue::isCell checked that the value was aligned.
Attachment 57785 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 JavaScriptCore/runtime/JSImmediate.h:47: CELL_MASK is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/runtime/JSImmediate.h:602: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 57788 [details] fixed style issue I did not fix the issue with having underscores in the name because it is a constant defined in Collector.h
Attachment 57788 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 JavaScriptCore/runtime/JSImmediate.h:47: CELL_MASK is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 57788 [details] fixed style issue I won't be able to review this, but I can let you know that you'll need a ChangeLog to make it through the review.
Created attachment 57820 [details] Changelogged
Attachment 57820 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 JavaScriptCore/runtime/JSImmediate.h:47: CELL_MASK is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 57820 [details] Changelogged > +#if !defined(NDEBUG) #ifndef NDEBUG is more idiomatic for this sort of thing. The rest of this looks fine.
Created attachment 59280 [details] changed #if !defined to #ifndef
Attachment 59280 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 JavaScriptCore/runtime/JSImmediate.h:47: CELL_MASK is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 59280 [details] changed #if !defined to #ifndef r=me When might JSValue::description() want to print INVALID()? (That's the kind of information that can be useful in a ChangeLog -- an explanation of "why", in addition to "what".)
Comment on attachment 57820 [details] Changelogged Cleared Darin Adler's review+ from obsolete attachment 57820 [details] so that this bug does not appear in http://webkit.org/pending-commit.
http://trac.webkit.org/changeset/61778