RESOLVED WONTFIX 40126
[Chromium] Add 'setJavaScriptProfilingEnabled' to WebDevToolsAgent, so it can be added to LayoutTestController 
https://bugs.webkit.org/show_bug.cgi?id=40126
Summary [Chromium] Add 'setJavaScriptProfilingEnabled' to WebDevToolsAgent, so it can...
Mikhail Naganov
Reported 2010-06-03 09:38:27 PDT
This is needed for compatibility with WebKit's layout tests.
Attachments
patch (2.76 KB, patch)
2010-06-03 09:40 PDT, Mikhail Naganov 		mnaganov: commit-queue-
DetailsFormatted DiffDiff
untabify changelog (2.78 KB, patch)
2010-06-03 09:44 PDT, Mikhail Naganov 		mnaganov: review-
mnaganov: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mikhail Naganov
Comment 1 2010-06-03 09:40:36 PDT
Created attachment 57781 [details] patch
WebKit Review Bot
Comment 2 2010-06-03 09:41:48 PDT
Attachment 57781 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebKit/chromium/ChangeLog:6: Line contains tab character. [whitespace/tab] [5] WebKit/chromium/ChangeLog:7: Line contains tab character. [whitespace/tab] [5] Total errors found: 2 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Mikhail Naganov
Comment 3 2010-06-03 09:44:24 PDT
Created attachment 57782 [details] untabify changelog
Mikhail Naganov
Comment 4 2010-06-03 09:55:45 PDT
This is not needed. JS profiling is always enabled in Chromium's InspectorController, so LTC's method can be dummy.
Note You need to log in before you can comment on or make changes to this bug.