Bug 40109 - Web Inspector: a number of fixes that make InspectorController happy with null redirects.
Summary: Web Inspector: a number of fixes that make InspectorController happy with nul...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-03 02:07 PDT by Pavel Feldman
Modified: 2010-06-03 03:04 PDT (History)
5 users (show)

See Also:


Attachments
[PATCH] Proposed change. (7.71 KB, patch)
2010-06-03 02:14 PDT, Pavel Feldman
yurys: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2010-06-03 02:07:29 PDT
There is a layout test that fails when dev extras are enabled: LayoutTests/http/tests/misc/will-send-request-returns-null-on-redirect.html.
This case uncovered a set of problems I'd like to fix:
1. We should support null redirects (we will ignore them, but not crash)
2. We should make sure that inspector controller does not process network events when devextras are not enabled
3. We should make sure that DRT disables dev extras after the tests it enabled it for.

Patch to follow.
Comment 1 Pavel Feldman 2010-06-03 02:14:29 PDT
Created attachment 57746 [details]
[PATCH] Proposed change.
Comment 2 Pavel Feldman 2010-06-03 03:04:35 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/inspector/InspectorController.cpp
	M	WebKitTools/ChangeLog
	M	WebKitTools/DumpRenderTree/gtk/DumpRenderTree.cpp
	M	WebKitTools/DumpRenderTree/mac/DumpRenderTree.mm
	M	WebKitTools/DumpRenderTree/win/DumpRenderTree.cpp
Committed r60618