RESOLVED FIXED 40105
bad codecs.open in webkitpy/layout_tests/ports/websocket_server.py 
https://bugs.webkit.org/show_bug.cgi?id=40105
Summary bad codecs.open in webkitpy/layout_tests/ports/websocket_server.py
Fumitoshi Ukai
Reported 2010-06-03 00:03:49 PDT
In websocket_server.PyWebSocket.start() method, it open file by codecs.open(output_log, "utf-8"), but second parameter should be "r" here. Also, it would be nice to kill the websocket server process when the process is running, but url is not alive.
Attachments
Patch (1.95 KB, patch)
2010-06-03 00:17 PDT, Fumitoshi Ukai 		levin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Fumitoshi Ukai
Comment 1 2010-06-03 00:17:34 PDT
Created attachment 57739 [details] Patch
Fumitoshi Ukai
Comment 2 2010-06-03 22:15:17 PDT
Committed r60654: <http://trac.webkit.org/changeset/60654>
Note You need to log in before you can comment on or make changes to this bug.