Bug 40105 - bad codecs.open in webkitpy/layout_tests/ports/websocket_server.py
Summary: bad codecs.open in webkitpy/layout_tests/ports/websocket_server.py
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-03 00:03 PDT by Fumitoshi Ukai
Modified: 2010-06-03 22:15 PDT (History)
0 users

See Also:


Attachments
Patch (1.95 KB, patch)
2010-06-03 00:17 PDT, Fumitoshi Ukai
levin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Fumitoshi Ukai 2010-06-03 00:03:49 PDT
In websocket_server.PyWebSocket.start() method, it open file by codecs.open(output_log, "utf-8"), but second parameter should be "r" here.

Also, it would be nice to kill the websocket server process when the process is running, but url is not alive.
Comment 1 Fumitoshi Ukai 2010-06-03 00:17:34 PDT
Created attachment 57739 [details]
Patch
Comment 2 Fumitoshi Ukai 2010-06-03 22:15:17 PDT
Committed r60654: <http://trac.webkit.org/changeset/60654>