Bug 40104 - [chromium] refactor WebKit.gyp's DRT section so the conditions are less messy
Summary: [chromium] refactor WebKit.gyp's DRT section so the conditions are less messy
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Tony Chang
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-02 23:08 PDT by Tony Chang
Modified: 2010-06-03 00:10 PDT (History)
1 user (show)

See Also:


Attachments
Patch (6.14 KB, patch)
2010-06-02 23:10 PDT, Tony Chang
no flags Details | Formatted Diff | Diff
Patch (6.72 KB, patch)
2010-06-02 23:13 PDT, Tony Chang
tkent: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2010-06-02 23:08:37 PDT
[chromium] refactor WebKit.gyp's DRT section so the conditions are less messy
Comment 1 Tony Chang 2010-06-02 23:10:14 PDT
Created attachment 57736 [details]
Patch
Comment 2 Tony Chang 2010-06-02 23:13:07 PDT
Created attachment 57737 [details]
Patch
Comment 3 Tony Chang 2010-06-02 23:14:22 PDT
The new format is one if/else per platform type.  The code for generating the pak file has been consolidated in the OS!=win section.
Comment 4 Kent Tamura 2010-06-02 23:19:16 PDT
Comment on attachment 57737 [details]
Patch

OK
Comment 5 Tony Chang 2010-06-03 00:10:47 PDT
Committed r60610: <http://trac.webkit.org/changeset/60610>