RESOLVED FIXED 40098
[chromium] generate DumpRenderTree.pak on DRT linux 
https://bugs.webkit.org/show_bug.cgi?id=40098
Summary [chromium] generate DumpRenderTree.pak on DRT linux
Tony Chang
Reported 2010-06-02 19:11:36 PDT
[chromium] generate DumpRenderTree.pak on DRT linux
Attachments
Patch (2.78 KB, patch)
2010-06-02 19:11 PDT, Tony Chang 		tkent: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tony Chang
Comment 1 2010-06-02 19:11:58 PDT
Created attachment 57726 [details] Patch
Kent Tamura
Comment 2 2010-06-02 19:18:03 PDT
Comment on attachment 57726 [details] Patch WebKit/chromium/WebKit.gyp:643 + ['OS=="linux" or OS=="freebsd" or OS=="openbsd"', { nit: Add "solaris" too?
Tony Chang
Comment 3 2010-06-02 20:22:18 PDT
Committed r60596: <http://trac.webkit.org/changeset/60596>
Tony Chang
Comment 4 2010-06-02 20:22:42 PDT
(In reply to comment #2) > (From update of attachment 57726 [details]) > WebKit/chromium/WebKit.gyp:643 > + ['OS=="linux" or OS=="freebsd" or OS=="openbsd"', { > nit: Add "solaris" too? Good idea, fixed before landing.
Kent Tamura
Comment 5 2010-06-02 22:29:05 PDT
Comment on attachment 57726 [details] Patch WebKit/chromium/WebKit.gyp:662 + 'repack_path': './tools/data_pack/repack.py', This path doesn't work in Chromium tree. Could you fix it please?
Tony Chang
Comment 6 2010-06-02 22:46:19 PDT
(In reply to comment #5) > (From update of attachment 57726 [details]) > WebKit/chromium/WebKit.gyp:662 > + 'repack_path': './tools/data_pack/repack.py', > This path doesn't work in Chromium tree. > Could you fix it please? Yes, sorry, I just submitted http://trac.webkit.org/changeset/60607 for this. I think we can merge the mac & linux code for this as well. I will try it.
Kent Tamura
Comment 7 2010-06-02 22:48:16 PDT
Thank you for the quick fix!
Note You need to log in before you can comment on or make changes to this bug.