Bug 40098 - [chromium] generate DumpRenderTree.pak on DRT linux
Summary: [chromium] generate DumpRenderTree.pak on DRT linux
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Tony Chang
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-02 19:11 PDT by Tony Chang
Modified: 2010-06-02 22:48 PDT (History)
1 user (show)

See Also:


Attachments
Patch (2.78 KB, patch)
2010-06-02 19:11 PDT, Tony Chang
tkent: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2010-06-02 19:11:36 PDT
[chromium] generate DumpRenderTree.pak on DRT linux
Comment 1 Tony Chang 2010-06-02 19:11:58 PDT
Created attachment 57726 [details]
Patch
Comment 2 Kent Tamura 2010-06-02 19:18:03 PDT
Comment on attachment 57726 [details]
Patch

WebKit/chromium/WebKit.gyp:643
 +                  ['OS=="linux" or OS=="freebsd" or OS=="openbsd"', {
nit: Add "solaris" too?
Comment 3 Tony Chang 2010-06-02 20:22:18 PDT
Committed r60596: <http://trac.webkit.org/changeset/60596>
Comment 4 Tony Chang 2010-06-02 20:22:42 PDT
(In reply to comment #2)
> (From update of attachment 57726 [details])
> WebKit/chromium/WebKit.gyp:643
>  +                  ['OS=="linux" or OS=="freebsd" or OS=="openbsd"', {
> nit: Add "solaris" too?


Good idea, fixed before landing.
Comment 5 Kent Tamura 2010-06-02 22:29:05 PDT
Comment on attachment 57726 [details]
Patch

WebKit/chromium/WebKit.gyp:662
 +                                  'repack_path': './tools/data_pack/repack.py',
This path doesn't work in Chromium tree.
Could you fix it please?
Comment 6 Tony Chang 2010-06-02 22:46:19 PDT
(In reply to comment #5)
> (From update of attachment 57726 [details])
> WebKit/chromium/WebKit.gyp:662
>  +                                  'repack_path': './tools/data_pack/repack.py',
> This path doesn't work in Chromium tree.
> Could you fix it please?

Yes, sorry, I just submitted http://trac.webkit.org/changeset/60607 for this.  I think we can merge the mac & linux code for this as well.  I will try it.
Comment 7 Kent Tamura 2010-06-02 22:48:16 PDT
Thank you for the quick fix!