Bug 40090 – Set attributes.stencil to false by default at context creation

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGL

[Zhenyao Mo]

Seemed like on certain Mac with ATI cards, turning on stencil causes fps to drop tremendously.

See https://bugs.webkit.org/show_bug.cgi?id=38560.

[Kenneth Russell]

This requires a WebGL specification change, but one which has basically already been agreed upon by the WebGL working group.

[Zhenyao Mo]

Created attachment 57718 [details]
patch

[Kenneth Russell]

(In reply to comment #2)
> Created an attachment (id=57718) [details]
> patch

This looks okay, but it must not be committed until the associated changes have been made to the WebGL spec. I'll try to get this approved by the working group tomorrow morning.

Are all of the other WebGL layout tests working with this change? In other words, there weren't any others dependent on the previous default of stencil=true?

[Zhenyao Mo]

Yes, all the tests pass with this change.

[David Levin]

Comment on attachment 57718 [details]
patch

Please set the r?/cq? when "the associated changes have been made to the WebGL spec" since "it must not be committed until" then.

Until then it is just cluttering a really full review queue and nothing can be done for it.

[Kenneth Russell]

The WebGL spec has been updated to indicate that the default value of the stencil flag is false.

The patch looks good to me.

[Dimitri Glazkov (Google)]

Comment on attachment 57718 [details]
patch

ok.

[WebKit Commit Bot]

Comment on attachment 57718 [details]
patch

Clearing flags on attachment: 57718

Committed r60660: <http://trac.webkit.org/changeset/60660>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.