Bug 40090 - Set attributes.stencil to false by default at context creation
Summary: Set attributes.stencil to false by default at context creation
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Zhenyao Mo
Depends on:
Reported: 2010-06-02 17:02 PDT by Zhenyao Mo
Modified: 2010-06-04 00:42 PDT (History)
4 users (show)

See Also:

patch (3.28 KB, patch)
2010-06-02 17:34 PDT, Zhenyao Mo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zhenyao Mo 2010-06-02 17:02:57 PDT
Seemed like on certain Mac with ATI cards, turning on stencil causes fps to drop tremendously.

See https://bugs.webkit.org/show_bug.cgi?id=38560.
Comment 1 Kenneth Russell 2010-06-02 17:04:36 PDT
This requires a WebGL specification change, but one which has basically already been agreed upon by the WebGL working group.
Comment 2 Zhenyao Mo 2010-06-02 17:34:39 PDT
Created attachment 57718 [details]
Comment 3 Kenneth Russell 2010-06-02 17:55:16 PDT
(In reply to comment #2)
> Created an attachment (id=57718) [details]
> patch

This looks okay, but it must not be committed until the associated changes have been made to the WebGL spec. I'll try to get this approved by the working group tomorrow morning.

Are all of the other WebGL layout tests working with this change? In other words, there weren't any others dependent on the previous default of stencil=true?
Comment 4 Zhenyao Mo 2010-06-02 18:44:52 PDT
Yes, all the tests pass with this change.
Comment 5 David Levin 2010-06-02 19:56:05 PDT
Comment on attachment 57718 [details]

Please set the r?/cq? when "the associated changes have been made to the WebGL spec" since "it must not be committed until" then.

Until then it is just cluttering a really full review queue and nothing can be done for it.
Comment 6 Kenneth Russell 2010-06-03 12:21:55 PDT
The WebGL spec has been updated to indicate that the default value of the stencil flag is false.

The patch looks good to me.
Comment 7 Dimitri Glazkov (Google) 2010-06-03 13:46:52 PDT
Comment on attachment 57718 [details]

Comment 8 WebKit Commit Bot 2010-06-04 00:42:15 PDT
Comment on attachment 57718 [details]

Clearing flags on attachment: 57718

Committed r60660: <http://trac.webkit.org/changeset/60660>
Comment 9 WebKit Commit Bot 2010-06-04 00:42:24 PDT
All reviewed patches have been landed.  Closing bug.