Geolocation callbacks should make use of new callback generation mechanism. This will remove the need for the Geolocation custom callback code. See the equivalent change for Database in http://trac.webkit.org/changeset/58801
Bug 40071 is adding a weak pointer wrapper around ScriptExecutionContext. This is required for Bug 39879 which fixes a Geolocation crash. We should hold off on switching to the generated callbacks until this is complete and Geolocation tests are in place to check the behavior.
The resolution of Bug 40071 was to not use a weak wrapper around ScriptExecutionContext, but instead to make callbacks inherit from ActiveDOMObject. The (hand written) Geolocation callbacks were updated to use this approach in http://trac.webkit.org/changeset/60840
http://trac.webkit.org/changeset/58801 updated the bindings script to automatically generate callbacks, and updated all DB callbacks to be automatically generated. The automatically generated callbacks were updated in http://trac.webkit.org/changeset/64537 to use ActiveDOMObject, similar to how the Geolocation callbacks do.
So we should now be able to switch to the automatically generated callbacks for Geolocation.
Note that there is ongoing discussion about a more fundamental refactoring of Geolocation - https://bugs.webkit.org/show_bug.cgi?id=40162 - but I think that eliminating custom bindings code still makes sense now.
Adding Leandro as this will be relevant to Media Streaming. See Bug 56459.
Created attachment 89361 [details]
Attachment 89361 [details] did not build on mac:
Build output: http://queues.webkit.org/results/8404205
Attachment 89361 [details] did not build on win:
Build output: http://queues.webkit.org/results/8401286
Created attachment 89382 [details]
Comment on attachment 89382 [details]
Um. I like deleting code. So rs=me.
Created attachment 94505 [details]
Not for review.
Rebased to account for deletion of android Makefiles. Will wait for bots to cycle before submitting.
Comment on attachment 94505 [details]
Attachment 94505 [details] did not pass mac-ews (mac):
Created attachment 94586 [details]
Committed r87143: <http://trac.webkit.org/changeset/87143>