RESOLVED FIXED 40065
Geolocation callbacks should make use of new callback generation mechanism
https://bugs.webkit.org/show_bug.cgi?id=40065
Summary Geolocation callbacks should make use of new callback generation mechanism
Steve Block
Reported 2010-06-02 08:24:53 PDT
Geolocation callbacks should make use of new callback generation mechanism. This will remove the need for the Geolocation custom callback code. See the equivalent change for Database in http://trac.webkit.org/changeset/58801
Attachments
Patch (55.27 KB, patch)
2011-04-13 03:57 PDT, Steve Block
no flags
Patch (68.99 KB, patch)
2011-04-13 08:47 PDT, Steve Block
no flags
Patch (52.04 KB, patch)
2011-05-23 15:36 PDT, Steve Block
no flags
Patch (65.94 KB, patch)
2011-05-24 02:38 PDT, Steve Block
no flags
Steve Block
Comment 1 2010-06-02 11:12:18 PDT
Bug 40071 is adding a weak pointer wrapper around ScriptExecutionContext. This is required for Bug 39879 which fixes a Geolocation crash. We should hold off on switching to the generated callbacks until this is complete and Geolocation tests are in place to check the behavior.
Steve Block
Comment 2 2011-03-24 03:55:46 PDT
The resolution of Bug 40071 was to not use a weak wrapper around ScriptExecutionContext, but instead to make callbacks inherit from ActiveDOMObject. The (hand written) Geolocation callbacks were updated to use this approach in http://trac.webkit.org/changeset/60840 http://trac.webkit.org/changeset/58801 updated the bindings script to automatically generate callbacks, and updated all DB callbacks to be automatically generated. The automatically generated callbacks were updated in http://trac.webkit.org/changeset/64537 to use ActiveDOMObject, similar to how the Geolocation callbacks do. So we should now be able to switch to the automatically generated callbacks for Geolocation. Note that there is ongoing discussion about a more fundamental refactoring of Geolocation - https://bugs.webkit.org/show_bug.cgi?id=40162 - but I think that eliminating custom bindings code still makes sense now.
Steve Block
Comment 3 2011-03-24 04:07:18 PDT
Adding Leandro as this will be relevant to Media Streaming. See Bug 56459.
Steve Block
Comment 4 2011-04-13 03:57:52 PDT
Daniel Bates
Comment 5 2011-04-13 04:30:58 PDT
Build Bot
Comment 6 2011-04-13 05:20:30 PDT
Steve Block
Comment 7 2011-04-13 08:47:33 PDT
Eric Seidel (no email)
Comment 8 2011-05-23 15:15:48 PDT
Comment on attachment 89382 [details] Patch Um. I like deleting code. So rs=me.
Steve Block
Comment 9 2011-05-23 15:36:57 PDT
Steve Block
Comment 10 2011-05-23 15:39:52 PDT
Not for review. Rebased to account for deletion of android Makefiles. Will wait for bots to cycle before submitting.
WebKit Commit Bot
Comment 11 2011-05-23 22:45:03 PDT
Steve Block
Comment 12 2011-05-24 02:38:49 PDT
Steve Block
Comment 13 2011-05-24 03:54:48 PDT
Note You need to log in before you can comment on or make changes to this bug.