Bug 40046 - [gtk] Compilation error when you disable DRAG SUPPORT.
Summary: [gtk] Compilation error when you disable DRAG SUPPORT.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-01 23:58 PDT by deepak
Modified: 2014-02-03 07:57 PST (History)
4 users (show)

See Also:


Attachments
Fix compilation when DRAG_SUPPORT disabled (1015 bytes, patch)
2010-06-02 00:02 PDT, deepak
levin: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description deepak 2010-06-01 23:58:15 PDT
Hi,
        
  There was a compilation error when you disable DRAG SUPPORT.
  ENABLE(DRAG_SUPPORT) wrappers were missing in WebCore/page/gtk/EventHandlerGtk.cpp

  Since i was using release version i checked out EventHandlerGtk.cpp from nightly build and manually created patch using diff and added changelog.
Comment 1 deepak 2010-06-02 00:02:23 PDT
Created attachment 57629 [details]
Fix compilation when DRAG_SUPPORT disabled



This will add missing ENABLE(DRAG_SUPPORT) in WebCore/page/gtk/EventHandlerGtk.cpp
Comment 2 David Levin 2010-06-02 00:59:11 PDT
Comment on attachment 57629 [details]
Fix compilation when DRAG_SUPPORT disabled

> 2010-06-02  Deepak Mundra  <deepak.m@allaboutif.com>
> 
>         Reviewed by NOBODY (OOPS!).
> 
>         Fix compilation, when you disable DRAG SUPPORT.
>         ENABLE(DRAG_SUPPORT) wrappers were missing in WebCore/page/gtk/EventHandlerGtk.cpp.

The general idea looks great, but this patch isn't well formed, so it doesn't apply on the bots and it wouldn't go through using the commit queue.

It looks like you may have a ChangeLog but the file that it applies to is not in the patch. If you need help preparing your patch, please see http://webkit.org/coding/contributing.html.

Note that this ChangeLog is missing a *bug link* which is also typical for ChangeLog entries.


when you put the patch up for review again, consider marking it commit-queue? so that the reviewer will also mark it as commit-queue+ and it will get committed for you.
Comment 3 Deepak Mittal 2014-02-03 07:38:22 PST
Changes already came in the latest code and it is building properly so closing this issue as Fixed.
Comment 4 Zan Dobersek 2014-02-03 07:57:45 PST
OK, thanks for reporting back.