Bug 40046 – [gtk] Compilation error when you disable DRAG SUPPORT.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[deepak]

Hi,
        
  There was a compilation error when you disable DRAG SUPPORT.
  ENABLE(DRAG_SUPPORT) wrappers were missing in WebCore/page/gtk/EventHandlerGtk.cpp

  Since i was using release version i checked out EventHandlerGtk.cpp from nightly build and manually created patch using diff and added changelog.

[deepak]

Created attachment 57629 [details]
Fix compilation when DRAG_SUPPORT disabled



This will add missing ENABLE(DRAG_SUPPORT) in WebCore/page/gtk/EventHandlerGtk.cpp

[David Levin]

Comment on attachment 57629 [details]
Fix compilation when DRAG_SUPPORT disabled

> 2010-06-02  Deepak Mundra  <[e-mail]>
> 
>         Reviewed by NOBODY (OOPS!).
> 
>         Fix compilation, when you disable DRAG SUPPORT.
>         ENABLE(DRAG_SUPPORT) wrappers were missing in WebCore/page/gtk/EventHandlerGtk.cpp.

The general idea looks great, but this patch isn't well formed, so it doesn't apply on the bots and it wouldn't go through using the commit queue.

It looks like you may have a ChangeLog but the file that it applies to is not in the patch. If you need help preparing your patch, please see http://webkit.org/coding/contributing.html.

Note that this ChangeLog is missing a *bug link* which is also typical for ChangeLog entries.


when you put the patch up for review again, consider marking it commit-queue? so that the reviewer will also mark it as commit-queue+ and it will get committed for you.

[Deepak Mittal]

Changes already came in the latest code and it is building properly so closing this issue as Fixed.

[Zan Dobersek]

OK, thanks for reporting back.