Bug 40040 - Web Inspector: Timeline should nicely format the Timer timeout
Summary: Web Inspector: Timeline should nicely format the Timer timeout
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-01 21:12 PDT by Joseph Pecoraro
Modified: 2010-06-02 02:54 PDT (History)
9 users (show)

See Also:


Attachments
[PATCH] Use Number.secondsToString (1.54 KB, patch)
2010-06-01 21:15 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2010-06-01 21:12:35 PDT
Given the following:

  setTimeout(function(){}, 15000);

I expected to see "15s" in the info bubble for the Timer on the Timeline panel.
Instead I saw the unitless 15000.

Is this worth testing? Its just a matter of applying the number formatter.
Comment 1 Joseph Pecoraro 2010-06-01 21:15:18 PDT
Created attachment 57618 [details]
[PATCH] Use Number.secondsToString

I like this formatter, because it will turn 15000 into 15s.

However, it does round. So 12345 becomes 12.35s.
Comment 2 WebKit Commit Bot 2010-06-02 02:54:40 PDT
Comment on attachment 57618 [details]
[PATCH] Use Number.secondsToString

Clearing flags on attachment: 57618

Committed r60552: <http://trac.webkit.org/changeset/60552>
Comment 3 WebKit Commit Bot 2010-06-02 02:54:46 PDT
All reviewed patches have been landed.  Closing bug.