Bug 40030 - [chromium] Layer compositor fails on ASSERT when updating layer contents
Summary: [chromium] Layer compositor fails on ASSERT when updating layer contents
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-01 17:37 PDT by Vangelis Kokkevis
Modified: 2010-06-02 02:02 PDT (History)
2 users (show)

See Also:

Attachments
Proposed patch (2.17 KB, patch)
2010-06-01 18:12 PDT, Vangelis Kokkevis 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vangelis Kokkevis 2010-06-01 17:37:46 PDT 
This happens infrequently but when the dirtyRect of a composited layer contains portions that fall outside the layer's bounds, the code that updates the contents of the layer's texture (LayerChromium::updateTextureContents()) hits an assert. The solution is to clip the dirty region to the bounds of the layer since that's the only visible portion anyway.
Comment 1 Vangelis Kokkevis 2010-06-01 18:12:43 PDT 
Created attachment 57610 [details]
Proposed patch
Comment 2 Dimitri Glazkov (Google) 2010-06-01 19:05:14 PDT 
Comment on attachment 57610 [details]
Proposed patch

sounds good.
Comment 3 WebKit Commit Bot 2010-06-02 02:01:59 PDT 
Comment on attachment 57610 [details]
Proposed patch

Clearing flags on attachment: 57610

Committed r60548: <http://trac.webkit.org/changeset/60548>
Comment 4 WebKit Commit Bot 2010-06-02 02:02:05 PDT 
All reviewed patches have been landed.  Closing bug.