Bug 40022 - [chromium] Convert shaders used by the GL compositor to use GLSL ES
Summary: [chromium] Convert shaders used by the GL compositor to use GLSL ES
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-01 13:07 PDT by Vangelis Kokkevis
Modified: 2010-06-02 02:50 PDT (History)
6 users (show)

See Also:


Attachments
Proposed patch (2.77 KB, patch)
2010-06-01 13:41 PDT, Vangelis Kokkevis
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vangelis Kokkevis 2010-06-01 13:07:35 PDT
Currently fragment shaders used by LayerRendererChromium are not valid GLSL ES shaders as they don't supply a precision qualifier. The GPU process has recently been modified to only accept GLSL ES shaders.
Comment 1 Vangelis Kokkevis 2010-06-01 13:41:23 PDT
Created attachment 57591 [details]
Proposed patch
Comment 2 WebKit Commit Bot 2010-06-02 01:18:40 PDT
Comment on attachment 57591 [details]
Proposed patch

Clearing flags on attachment: 57591

Committed r60545: <http://trac.webkit.org/changeset/60545>
Comment 3 WebKit Commit Bot 2010-06-02 01:18:45 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Csaba Osztrogonác 2010-06-02 02:50:38 PDT
(In reply to comment #4)
> http://trac.webkit.org/changeset/60545 might have broken Qt Linux Release
> The following changes are on the blame list:
> http://trac.webkit.org/changeset/60544
> http://trac.webkit.org/changeset/60545
> http://trac.webkit.org/changeset/60546
> http://trac.webkit.org/changeset/60547
> http://trac.webkit.org/changeset/60543

This patch is innocent, another one is the culprit, sorry for the SPAM.