Bug 40016 – [Qt] Make possible run DRT with QGraphicsWebView

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Diego Gonzalez]

Make possible to use a environment variable for switching backend.
Usage: QT_DRT_WEBVIEW_MODE=graphics WebKitTools/Scripts/run-webkit-tests --qt

[Diego Gonzalez]

Created attachment 57578 [details]
Patch

[Kenneth Rohde Christiansen]

Comment on attachment 57578 [details]
Patch

Cool patch Diego :-) nice work. So what is the status about the tests? Now many are not passing?

r=me, but please send an email to the list announcing this and let's wait a day before committing, just to make sure that no one have objections.

Have you talked to Ossy about this already?

[Csaba Osztrogonác]

(In reply to comment #2)
> (From update of attachment 57578 [details])
> Cool patch Diego :-) nice work. So what is the status about the tests? Now many are not passing?
> 
> r=me, but please send an email to the list announcing this and let's wait a day before committing, just to make sure that no one have objections.
> 
> Have you talked to Ossy about this already?

Without QT_DRT_WEBVIEW_MODE=graphics environment variable 
there aren't any regression on ToT. With this option I got 
similar results as Diego mentioned on webkit-qt mailing list.

[Diego Gonzalez]

(In reply to comment #3)
> Without QT_DRT_WEBVIEW_MODE=graphics environment variable 
> there aren't any regression on ToT. With this option I got 
> similar results as Diego mentioned on webkit-qt mailing list.

Thanks Ossy :)

[WebKit Commit Bot]

Comment on attachment 57578 [details]
Patch

Clearing flags on attachment: 57578

Committed r60586: <http://trac.webkit.org/changeset/60586>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.