Bug 40016 - [Qt] Make possible run DRT with QGraphicsWebView
Summary: [Qt] Make possible run DRT with QGraphicsWebView
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Diego Gonzalez
URL:
Keywords: Qt
Depends on:
Blocks: 40014
  Show dependency treegraph
 
Reported: 2010-06-01 11:56 PDT by Diego Gonzalez
Modified: 2010-06-02 18:33 PDT (History)
4 users (show)

See Also:


Attachments
Patch (6.39 KB, patch)
2010-06-01 12:16 PDT, Diego Gonzalez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Gonzalez 2010-06-01 11:56:50 PDT
Make possible to use a environment variable for switching backend.
Usage: QT_DRT_WEBVIEW_MODE=graphics WebKitTools/Scripts/run-webkit-tests --qt
Comment 1 Diego Gonzalez 2010-06-01 12:16:37 PDT
Created attachment 57578 [details]
Patch
Comment 2 Kenneth Rohde Christiansen 2010-06-01 12:36:09 PDT
Comment on attachment 57578 [details]
Patch

Cool patch Diego :-) nice work. So what is the status about the tests? Now many are not passing?

r=me, but please send an email to the list announcing this and let's wait a day before committing, just to make sure that no one have objections.

Have you talked to Ossy about this already?
Comment 3 Csaba Osztrogonác 2010-06-02 09:51:30 PDT
(In reply to comment #2)
> (From update of attachment 57578 [details])
> Cool patch Diego :-) nice work. So what is the status about the tests? Now many are not passing?
> 
> r=me, but please send an email to the list announcing this and let's wait a day before committing, just to make sure that no one have objections.
> 
> Have you talked to Ossy about this already?

Without QT_DRT_WEBVIEW_MODE=graphics environment variable 
there aren't any regression on ToT. With this option I got 
similar results as Diego mentioned on webkit-qt mailing list.
Comment 4 Diego Gonzalez 2010-06-02 10:23:19 PDT
(In reply to comment #3)
> Without QT_DRT_WEBVIEW_MODE=graphics environment variable 
> there aren't any regression on ToT. With this option I got 
> similar results as Diego mentioned on webkit-qt mailing list.

Thanks Ossy :)
Comment 5 WebKit Commit Bot 2010-06-02 18:33:11 PDT
Comment on attachment 57578 [details]
Patch

Clearing flags on attachment: 57578

Committed r60586: <http://trac.webkit.org/changeset/60586>
Comment 6 WebKit Commit Bot 2010-06-02 18:33:17 PDT
All reviewed patches have been landed.  Closing bug.