Bug 40001 – Fix "variable may be used before being set" warning in TextResourceDecoder::checkForHeadCharset

• Status: RESOLVED
• Resolution: FIXED
• Component: Page Loading

[Laszlo Gombos]

The warning is coming from the RVCT compiler:

"\webkit\WebCore\loader\textresourcedecoder.cpp", line 571: Warning: C2874W: len may be used before being set
        int len;
            ^
Checking the code revealed that this might be a limitation of the compiler as the code is correct and the value of len never read before it gets initialized. I propose to initialize len to 0 just to eliminate the false compiler warning.

[Laszlo Gombos]

Created attachment 57548 [details]
proposed patch

[WebKit Commit Bot]

Comment on attachment 57548 [details]
proposed patch

Clearing flags on attachment: 57548

Committed r60529: <http://trac.webkit.org/changeset/60529>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Review Bot]

http://trac.webkit.org/changeset/60529 might have broken GTK Linux 32-bit Release
The following changes are on the blame list:
http://trac.webkit.org/changeset/60528
http://trac.webkit.org/changeset/60529
http://trac.webkit.org/changeset/60530

[Darin Adler]

(In reply to comment #0)
> The warning is coming from the RVCT compiler:
> 
> "\webkit\WebCore\loader\textresourcedecoder.cpp", line 571: Warning: C2874W: len may be used before being set
>         int len;
>             ^
> Checking the code revealed that this might be a limitation of the compiler as the code is correct and the value of len never read before it gets initialized. I propose to initialize len to 0 just to eliminate the false compiler warning.

I'm not sure this is a good precedent. It's OK to change code to sidestep a mistaken warning, but this is the kind of thing that occurs in many places and I don't want to include lots of extra initialization just to quiet the compiler.

Unless you think there's another reason that this kind of code change is good.