The Geolocation LayoutTests should guard calls to LayoutTestController methods with 'if (window.layoutTestController)' and should make it clear if the test can not pass without LayoutTestController.
Created attachment 57539 [details] Patch
Created attachment 57589 [details] Patch
LGTM, but i have an unrelated question about the .js files in fast/dom/Geolocation/script-tests/. lots of them seem to have code that looks like this: }, function(e) { error = e shouldBe('error.code', 'mockCode'); shouldBe('error.message', 'mockMessage'); ... shouldn't there be a ';' after 'error = e' (at least from a style point of view)?
> shouldn't there be a ';' after 'error = e' (at least from a style point of view)? Yes, good catch. I can fix this on landing if that's OK with you?
That's fine with me. Please go through every .js file as quite a few of them seem to have this issue. Oh, and you're still going to need an official r+ from somebody else since I'm not a reviewer... sorry. :)
Created attachment 57856 [details] Patch
Comment on attachment 57856 [details] Patch r=me
Committed r60667: <http://trac.webkit.org/changeset/60667>