Bug 39983 – webkit-patch fails in Chromium/WebKit git checkout under Cygwin in Windows 7

• Status: RESOLVED
• Resolution: WONTFIX
• Component: Tools / Tests

[Roland Steiner]

Trying to run 'webkit-patch upload' in a git checkout within a Chromium git repository, I receive the following error messages

$ ./WebKitTools/Scripts/webkit-patch upload
Running check-webkit-style
Traceback (most recent call last):
  File "./WebKitTools/Scripts/webkit-patch", line 64, in <module>
    main()
  File "./WebKitTools/Scripts/webkit-patch", line 59, in main
    WebKitPatch(__file__).main()
  File "C:\dev\cgit\src\third_party\WebKit\WebKitTools\Scripts\webkitpy\tool\multicommandtool.py", line 302, in main
    result = command.check_arguments_and_execute(options, args, self)
  File "C:\dev\cgit\src\third_party\WebKit\WebKitTools\Scripts\webkitpy\tool\multicommandtool.py", line 113, in check_arguments_and_execute
    return self.execute(options, args, tool) or 0
  File "C:\dev\cgit\src\third_party\WebKit\WebKitTools\Scripts\webkitpy\tool\commands\abstractsequencedcommand.py", line 43, in execute
    self._sequence.run_and_handle_errors(tool, options, self._prepare_state(options, args, tool))
  File "C:\dev\cgit\src\third_party\WebKit\WebKitTools\Scripts\webkitpy\tool\commands\stepsequence.py", line 66, in run_and_handle_errors
    self._run(tool, options, state)
  File "C:\dev\cgit\src\third_party\WebKit\WebKitTools\Scripts\webkitpy\tool\commands\stepsequence.py", line 60, in _run
    step(tool, options).run(state)
  File "C:\dev\cgit\src\third_party\WebKit\WebKitTools\Scripts\webkitpy\tool\steps\checkstyle.py", line 62, in run
    self._run_script("check-webkit-style", args)
  File "C:\dev\cgit\src\third_party\WebKit\WebKitTools\Scripts\webkitpy\tool\steps\abstractstep.py", line 46, in _run_script
    self._tool.executive.run_and_throw_if_fail(command, quiet)
  File "C:\dev\cgit\src\third_party\WebKit\WebKitTools\Scripts\webkitpy\common\system\executive.py", line 137, in run_and_throw_if_fail
    exit_code = self._run_command_with_teed_output(args, child_stdout)
  File "C:\dev\cgit\src\third_party\WebKit\WebKitTools\Scripts\webkitpy\common\system\executive.py", line 109, in _run_command_with_teed_output
    close_fds=self._should_close_fds())
  File "C:\dev\depot_tools\python_bin\lib\subprocess.py", line 595, in __init__
    errread, errwrite)
  File "C:\dev\depot_tools\python_bin\lib\subprocess.py", line 804, in _execute_child
    startupinfo)
WindowsError: [Error 2] The system cannot find the file specified


Note that just running 'check-webkit-style' succeeds.

[Stephen Chenney]

LayoutTest failures for Chromium are being marked WontFix. The Bug is still accessible and referenced from TestExpectations.