Bug 39968 - [Qt] Shared platform plugin
Summary: [Qt] Shared platform plugin
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P3 Normal
Assignee: Luiz Agostini
URL:
Keywords: Qt
Depends on:
Blocks: 39970 40005
  Show dependency treegraph
 
Reported: 2010-05-31 13:44 PDT by Luiz Agostini
Modified: 2010-08-03 08:45 PDT (History)
5 users (show)

See Also:


Attachments
patch 1 (4.19 KB, patch)
2010-05-31 13:51 PDT, Luiz Agostini
no flags Details | Formatted Diff | Diff
patch 2 (6.59 KB, patch)
2010-06-01 12:15 PDT, Luiz Agostini
no flags Details | Formatted Diff | Diff
patch 3 (6.96 KB, patch)
2010-06-02 13:35 PDT, Luiz Agostini
no flags Details | Formatted Diff | Diff
patch 4 (7.01 KB, patch)
2010-06-02 13:48 PDT, Luiz Agostini
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Luiz Agostini 2010-05-31 13:44:13 PDT
Current implementation does not allow many instances of QtPlatformPlugin to share the QWebKitPlatformPlugin object provided by the plugin.
Comment 1 Luiz Agostini 2010-05-31 13:51:22 PDT
Created attachment 57493 [details]
patch 1
Comment 2 Luiz Agostini 2010-06-01 12:15:29 PDT
Created attachment 57577 [details]
patch 2
Comment 3 Laszlo Gombos 2010-06-01 14:04:12 PDT
load() could be expensive in a slow filesystem. It would be better not to go trough load() for each QtPlatformPlugin instance if they would refer the same plugin anyway.
Comment 4 Luiz Agostini 2010-06-02 13:35:58 PDT
Created attachment 57693 [details]
patch 3
Comment 5 Luiz Agostini 2010-06-02 13:48:14 PDT
Created attachment 57696 [details]
patch 4
Comment 6 Kenneth Rohde Christiansen 2010-06-02 14:00:12 PDT
Simon, what is the reason for the cq-?
Comment 7 Simon Hausmann 2010-06-02 14:05:22 PDT
Comment on attachment 57696 [details]
patch 4

Wrong click on my side :)
Comment 8 WebKit Commit Bot 2010-06-02 19:38:09 PDT
Comment on attachment 57696 [details]
patch 4

Clearing flags on attachment: 57696

Committed r60593: <http://trac.webkit.org/changeset/60593>
Comment 9 WebKit Commit Bot 2010-06-02 19:38:15 PDT
All reviewed patches have been landed.  Closing bug.
Comment 10 Simon Hausmann 2010-06-04 00:51:05 PDT
Removing from the 2.0 patch blocker. This feature is not part of the 2.0 branch.
Comment 11 Simon Hausmann 2010-08-03 08:45:51 PDT
Revision r60593 cherry-picked into qtwebkit-2.1 with commit 38fcdf0bf780edfcf4052f08984447b5fced0c3f