RESOLVED FIXED 39957
Chromium: save inspector settings as dictionary, not as string. 
https://bugs.webkit.org/show_bug.cgi?id=39957
Summary Chromium: save inspector settings as dictionary, not as string.
Pavel Podivilov
Reported 2010-05-31 08:28:52 PDT
Chromium: save inspector settings as dictionary, not as string.
Attachments
Proposed patch. (7.68 KB, patch)
2010-05-31 08:35 PDT, Pavel Podivilov 		pfeldman: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Podivilov
Comment 1 2010-05-31 08:35:10 PDT
Created attachment 57472 [details] Proposed patch.
Pavel Feldman
Comment 2 2010-05-31 09:14:49 PDT
Comment on attachment 57472 [details] Proposed patch. r+ with nits. WebKit/chromium/src/InspectorClientImpl.cpp:96 + m_inspectedWebView->inspectorSetting(key, &string); So it did not compile for you with simply putting 'value' as a second argument? WebKit/chromium/src/WebViewImpl.h:491 + typedef HashMap<WebCore::String, WebCore::String> SettingsMap; WebKit should operate WebKit strings. I know it was wrong, but it may be a good time to fix it.
Pavel Podivilov
Comment 3 2010-05-31 10:00:09 PDT
> WebKit/chromium/src/InspectorClientImpl.cpp:96 > + m_inspectedWebView->inspectorSetting(key, &string); > So it did not compile for you with simply putting 'value' as a second argument? Yep, it did not. > > > WebKit/chromium/src/WebViewImpl.h:491 > + typedef HashMap<WebCore::String, WebCore::String> SettingsMap; > WebKit should operate WebKit strings. I know it was wrong, but it may be a good time to fix it. We need a map here, because InspectorClient will ask for inspector settings by key.
Pavel Feldman
Comment 4 2010-06-01 02:06:20 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKit/chromium/ChangeLog M WebKit/chromium/public/WebView.h M WebKit/chromium/public/WebViewClient.h M WebKit/chromium/src/InspectorClientImpl.cpp M WebKit/chromium/src/InspectorClientImpl.h M WebKit/chromium/src/WebViewImpl.cpp M WebKit/chromium/src/WebViewImpl.h Committed r60469
Note You need to log in before you can comment on or make changes to this bug.