Bug 39952 - [v8] Web Inspector: allow hiding Scripts panel from Chromium code
Summary: [v8] Web Inspector: allow hiding Scripts panel from Chromium code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-31 05:51 PDT by Yury Semikhatsky
Modified: 2010-05-31 07:36 PDT (History)
2 users (show)

See Also:


Attachments
Patch (7.90 KB, patch)
2010-05-31 05:58 PDT, Yury Semikhatsky
no flags Details | Formatted Diff | Diff
Patch that I'm going to land. (7.91 KB, patch)
2010-05-31 07:10 PDT, Yury Semikhatsky
pfeldman: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2010-05-31 05:51:07 PDT
[v8] Web Inspector: allow hiding Scripts panel from Chromium code
Comment 1 Yury Semikhatsky 2010-05-31 05:58:58 PDT
Created attachment 57457 [details]
Patch
Comment 2 Pavel Feldman 2010-05-31 07:08:17 PDT
Comment on attachment 57457 [details]
Patch

WebKit/chromium/public/WebDevToolsFrontendClient.h:45
 +      virtual void sendDebuggerPauseScript()  {}
missed it!

WebKit/chromium/public/WebDevToolsFrontendClient.h:52
 +      virtual bool hideScriptsPanel() { return false; }
shouldHideScriptsPanel
Comment 3 Yury Semikhatsky 2010-05-31 07:10:40 PDT
Created attachment 57460 [details]
Patch that I'm going to land.
Comment 4 Yury Semikhatsky 2010-05-31 07:11:26 PDT
(In reply to comment #2)
> (From update of attachment 57457 [details])
> WebKit/chromium/public/WebDevToolsFrontendClient.h:45
>  +      virtual void sendDebuggerPauseScript()  {}
> missed it!
> 
Fixed.

> WebKit/chromium/public/WebDevToolsFrontendClient.h:52
>  +      virtual bool hideScriptsPanel() { return false; }
> shouldHideScriptsPanel
Done.
Comment 5 Yury Semikhatsky 2010-05-31 07:36:53 PDT
Committed r60436