Bug 39913 - [chromium API] Expose html5 parser enable flag
Summary: [chromium API] Expose html5 parser enable flag
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: James Robinson
URL:
Keywords:
: 39914 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-05-28 16:23 PDT by James Robinson
Modified: 2010-05-31 23:21 PDT (History)
2 users (show)

See Also:


Attachments
Patch (2.34 KB, patch)
2010-05-28 16:31 PDT, James Robinson
no flags Details | Formatted Diff | Diff
Patch (2.34 KB, patch)
2010-05-28 16:34 PDT, James Robinson
fishd: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Robinson 2010-05-28 16:23:30 PDT
[chromium API] Expose html5 parser enable flag
Comment 1 James Robinson 2010-05-28 16:29:41 PDT
*** Bug 39914 has been marked as a duplicate of this bug. ***
Comment 2 James Robinson 2010-05-28 16:31:27 PDT
Created attachment 57393 [details]
Patch
Comment 3 James Robinson 2010-05-28 16:34:24 PDT
Created attachment 57394 [details]
Patch
Comment 4 WebKit Commit Bot 2010-05-29 14:04:05 PDT
Comment on attachment 57394 [details]
Patch

Rejecting patch 57394 from commit-queue.

Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Darin Fisher', u'--force']" exit_code: 1
Last 500 characters of output:
 WebKit/chromium/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file WebKit/chromium/public/WebSettings.h
Hunk #1 FAILED at 90.
1 out of 1 hunk FAILED -- saving rejects to file WebKit/chromium/public/WebSettings.h.rej
patching file WebKit/chromium/src/WebSettingsImpl.cpp
Hunk #1 succeeded at 279 with fuzz 1 (offset 5 lines).
patching file WebKit/chromium/src/WebSettingsImpl.h
Hunk #1 FAILED at 86.
1 out of 1 hunk FAILED -- saving rejects to file WebKit/chromium/src/WebSettingsImpl.h.rej

Full output: http://webkit-commit-queue.appspot.com/results/2600095
Comment 5 James Robinson 2010-05-30 22:25:32 PDT
Looks like this collided with http://trac.webkit.org/changeset/60411.  I guess this is why people avoid append-at-the-end :).  Will resolve and land manually.
Comment 6 James Robinson 2010-05-31 23:21:33 PDT
Committed r60464: <http://trac.webkit.org/changeset/60464>