Bug 39899 – [EFL] Allow building of shared core libraries

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Leandro Pereira]

To speed up linking times in machines with a small amount of memory, one can use the attached patch to allow linking the core libraries as shared objects. This of course impacts load time, and should only be used when making changes to WebCore/WebCoreSupport.

[Leandro Pereira]

Created attachment 57374 [details]
 Allow building of shared core libraries

[Adam Treat]

Comment on attachment 57374 [details]
 Allow building of shared core libraries

The changes where you add files please put this in another patch in the future. Thanks!

[Leandro Pereira]

Created attachment 57669 [details]
[EFL] Allow building of shared core libraries

Same patch, without unrelated changes that managed to slip in.

[Leandro Pereira]

Created attachment 58032 [details]
[EFL] Allow building of shared core libraries

This patch was already reviewed by manyoso; uploading it again with his name on the reviewer line.

[WebKit Commit Bot]

Comment on attachment 58032 [details]
[EFL] Allow building of shared core libraries

Rejecting patch 58032 from review queue.

[e-mail] does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py.

- If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have reviewer rights please correct the error in WebKitTools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  Due to bug 30084 the commit-queue will require a restart after your change.  Please contact [e-mail] to request a commit-queue restart.  After restart the commit-queue will correctly respect your reviewer rights.

[WebKit Commit Bot]

Comment on attachment 58032 [details]
[EFL] Allow building of shared core libraries

Rejecting patch 58032 from commit-queue.

[e-mail] does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in WebKitTools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  Due to bug 30084 the commit-queue will require a restart after your change.  Please contact [e-mail] to request a commit-queue restart.  After restart the commit-queue will correctly respect your committer rights.

[Eric Seidel (no email)]

Comment on attachment 57374 [details]
 Allow building of shared core libraries

Cleared Adam Treat's review+ from obsolete attachment 57374 [details] so that this bug does not appear in http://webkit.org/pending-commit.

[Leandro Pereira]

Created attachment 58048 [details]
Allow building of shared core libraries

Resending the patch, to reset the flags. (Turns out the bots aren't so smart. :))

[WebKit Commit Bot]

Comment on attachment 58048 [details]
Allow building of shared core libraries

Clearing flags on attachment: 58048

Committed r60909: <http://trac.webkit.org/changeset/60909>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.