Bug 39898 - Move arity check into callee.
Summary: Move arity check into callee.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Gavin Barraclough
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-28 12:57 PDT by Gavin Barraclough
Modified: 2010-05-28 14:18 PDT (History)
0 users

See Also:

Attachments
The patch (36.71 KB, patch)
2010-05-28 13:02 PDT, Gavin Barraclough 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2010-05-28 12:57:55 PDT 
We can reduce the size of the virtual call trampolines by moving the arity check into the callee functions.  As a following step we will be able to remove the check for native function / codeblocks by performing translation in a lazy stub.
Comment 1 Gavin Barraclough 2010-05-28 13:02:30 PDT 
Created attachment 57365 [details]
The patch

no perf impact
Comment 2 Sam Weinig 2010-05-28 13:19:05 PDT 
Comment on attachment 57365 [details]
The patch

Please remove the commented out printfs before landing.

r=me.
Comment 3 Gavin Barraclough 2010-05-28 14:18:49 PDT 
Transmitting file data .........
Committed revision 60376.